From 829f8fd283ca72e2a3391580ecf748f1e99efe5c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Simon=20Pr=C3=A9vost?= <sprevost@mirego.com>
Date: Thu, 4 Apr 2024 21:37:28 -0400
Subject: [PATCH] Remove machine translation quick button revisions list. Fixes
 #423

---
 .../conflicts-list/item/component.ts          |  7 ++
 webapp/app/queries/translation-editions.ts    | 12 ---
 webapp/app/queries/translations.ts            |  1 +
 .../components/inline-machine-translate.scss  | 74 -------------------
 .../components/translations-list/item.scss    |  2 +-
 .../templates/components/conflicts-list.hbs   |  1 -
 .../components/conflicts-list/group.hbs       |  1 -
 .../components/conflicts-list/item.hbs        |  2 +-
 .../components/inline-machine-translate.hbs   | 28 +++----
 .../components/related-translations-list.hbs  |  1 -
 .../related-translations-list/item.hbs        |  2 +-
 .../templates/components/translation-edit.hbs |  2 +-
 .../components/translation-edit/helpers.hbs   |  2 +-
 .../translation-editions-list/item.hbs        |  2 +-
 .../components/translations-list/item.hbs     |  2 +-
 .../project/revision/translations.hbs         |  1 -
 .../logged-in/project/translation/index.hbs   |  1 -
 17 files changed, 24 insertions(+), 117 deletions(-)

diff --git a/webapp/app/components/conflicts-list/item/component.ts b/webapp/app/components/conflicts-list/item/component.ts
index 94093851d..02ec285da 100644
--- a/webapp/app/components/conflicts-list/item/component.ts
+++ b/webapp/app/components/conflicts-list/item/component.ts
@@ -78,6 +78,13 @@ export default class ConflictsListItem extends Component<Args> {
       : this.args.translation.revision.language.rtl;
   }
 
+  get revisionSlug() {
+    return (
+      this.args.translation.revision.slug ||
+      this.args.translation.revision.language.slug
+    );
+  }
+
   @action
   changeTranslationText(text: string) {
     this.textInput = text;
diff --git a/webapp/app/queries/translation-editions.ts b/webapp/app/queries/translation-editions.ts
index e4d9216d5..534d5c962 100644
--- a/webapp/app/queries/translation-editions.ts
+++ b/webapp/app/queries/translation-editions.ts
@@ -41,18 +41,6 @@ export default gql`
               tag
             }
 
-            revision {
-              id
-              slug
-              rtl
-
-              language {
-                id
-                slug
-                rtl
-              }
-            }
-
             document {
               id
               path
diff --git a/webapp/app/queries/translations.ts b/webapp/app/queries/translations.ts
index 72aedbdf3..77ab048c3 100644
--- a/webapp/app/queries/translations.ts
+++ b/webapp/app/queries/translations.ts
@@ -94,6 +94,7 @@ export default gql`
                   rtl
                 }
               }
+
               document {
                 id
                 path
diff --git a/webapp/app/styles/components/inline-machine-translate.scss b/webapp/app/styles/components/inline-machine-translate.scss
index 95740f369..e69de29bb 100644
--- a/webapp/app/styles/components/inline-machine-translate.scss
+++ b/webapp/app/styles/components/inline-machine-translate.scss
@@ -1,74 +0,0 @@
-.prompt-button {
-  position: relative;
-  display: flex;
-  align-items: center;
-
-  > .button {
-    transition: opacity 0.2s ease-in-out;
-    box-shadow: none;
-    opacity: 0.7;
-    border-radius: var(--border-radius);
-  }
-
-  > button:focus,
-  > button:hover {
-    transform: translate3d(0, 0, 0);
-  }
-
-  &:focus,
-  &:hover {
-    outline: none;
-
-    > .button {
-      opacity: 1;
-    }
-
-    .prompt-button-quick-access[data-rtl] {
-      transform: translateX(40px);
-    }
-
-    .prompt-button-quick-access {
-      opacity: 1;
-      transform: translateX(-40px);
-      padding: 0 5px;
-      pointer-events: all;
-    }
-  }
-}
-
-.prompt-button-quick-access[data-rtl] {
-  left: 0;
-  right: auto;
-  justify-content: flex-start;
-}
-
-.prompt-button-quick-access {
-  background: var(--input-background);
-  opacity: 0;
-  pointer-events: none;
-  border-radius: var(--border-radius);
-  right: 0;
-  display: flex;
-  gap: 0;
-  justify-content: flex-end;
-  align-items: center;
-  position: absolute;
-  top: 0;
-  transition: all 0.2s ease-in-out;
-
-  > button {
-    font-size: 11px;
-    flex-shrink: 0;
-  }
-
-  > button:focus,
-  > button:hover {
-    background: var(--background-light);
-    transform: translate3d(0, 0, 0);
-  }
-
-  > button :global(.label) {
-    padding-left: 8px;
-    padding-right: 8px;
-  }
-}
diff --git a/webapp/app/styles/components/translations-list/item.scss b/webapp/app/styles/components/translations-list/item.scss
index bc9353a38..87b81155d 100644
--- a/webapp/app/styles/components/translations-list/item.scss
+++ b/webapp/app/styles/components/translations-list/item.scss
@@ -194,7 +194,7 @@
 
 .item-updatedAt {
   opacity: 0;
-  transform: translateX(-10px);
+  transform: translateX(-5px);
   margin-left: 5px;
   color: var(--color-grey);
   font-size: 11px;
diff --git a/webapp/app/templates/components/conflicts-list.hbs b/webapp/app/templates/components/conflicts-list.hbs
index a0df53261..b8503f572 100644
--- a/webapp/app/templates/components/conflicts-list.hbs
+++ b/webapp/app/templates/components/conflicts-list.hbs
@@ -22,7 +22,6 @@
     <ConflictsList::Group
       @index={{index}}
       @permissions={{@permissions}}
-      @revisions={{this.revisions}}
       @project={{@project}}
       @prompts={{@prompts}}
       @groupedTranslation={{groupedTranslation}}
diff --git a/webapp/app/templates/components/conflicts-list/group.hbs b/webapp/app/templates/components/conflicts-list/group.hbs
index 2a99e398e..e2d1e4e76 100644
--- a/webapp/app/templates/components/conflicts-list/group.hbs
+++ b/webapp/app/templates/components/conflicts-list/group.hbs
@@ -23,7 +23,6 @@
         <ConflictsList::Item
           @permissions={{@permissions}}
           @project={{@project}}
-          @revisions={{@revisions}}
           @prompts={{@prompts}}
           @translation={{translation}}
           @onCorrect={{@onCorrect}}
diff --git a/webapp/app/templates/components/conflicts-list/item.hbs b/webapp/app/templates/components/conflicts-list/item.hbs
index 039630703..8d4da5a35 100644
--- a/webapp/app/templates/components/conflicts-list/item.hbs
+++ b/webapp/app/templates/components/conflicts-list/item.hbs
@@ -38,7 +38,7 @@
                 <TranslationEdit::Helpers
                   @permissions={{@permissions}}
                   @project={{@project}}
-                  @revisions={{@revisions}}
+                  @languageSlug={{this.revisionSlug}}
                   @prompts={{@prompts}}
                   @rtl={{this.revisionTextDirRtl}}
                   @text={{this.textInput}}
diff --git a/webapp/app/templates/components/inline-machine-translate.hbs b/webapp/app/templates/components/inline-machine-translate.hbs
index 9df40296c..bf5e9c1ae 100644
--- a/webapp/app/templates/components/inline-machine-translate.hbs
+++ b/webapp/app/templates/components/inline-machine-translate.hbs
@@ -1,19 +1,9 @@
-{{#if @languages}}
-  <div local-class='prompt-button' tabindex='0'>
-    <div local-class='prompt-button-quick-access' data-rtl={{@rtl}}>
-      {{#each @languages as |language|}}
-        <AsyncButton
-          title={{language.name}}
-          @onClick={{(perform this.submitTask language.slug)}}
-          class='tooltip tooltip--top button button--iconOnly button--borderless button--white'
-        >
-          {{language.slug}}
-        </AsyncButton>
-      {{/each}}
-    </div>
-
-    <button local-class='button' class='button button--iconOnly button--borderless button--filled button--white'>
-      {{inline-svg '/assets/language.svg' class='button-icon'}}
-    </button>
-  </div>
-{{/if}}
\ No newline at end of file
+<AsyncButton
+  local-class='button'
+  title={{@languageSlug}}
+  @onClick={{(perform this.submitTask @languageSlug)}}
+  @loading={{this.isSubmitting}}
+  class='button button--iconOnly button--borderless button--filled button--white'
+>
+  {{inline-svg '/assets/language.svg' class='button-icon'}}
+</AsyncButton>
\ No newline at end of file
diff --git a/webapp/app/templates/components/related-translations-list.hbs b/webapp/app/templates/components/related-translations-list.hbs
index d959f9463..9c28ccc94 100644
--- a/webapp/app/templates/components/related-translations-list.hbs
+++ b/webapp/app/templates/components/related-translations-list.hbs
@@ -4,7 +4,6 @@
       {{#each @translations key='id' as |translation|}}
         <RelatedTranslationsList::Item
           @permissions={{@permissions}}
-          @revisions={{@revisions}}
           @prompts={{@prompts}}
           @onUpdateText={{@onUpdateText}}
           @isInEditMode={{true}}
diff --git a/webapp/app/templates/components/related-translations-list/item.hbs b/webapp/app/templates/components/related-translations-list/item.hbs
index c125c1051..dac6be147 100644
--- a/webapp/app/templates/components/related-translations-list/item.hbs
+++ b/webapp/app/templates/components/related-translations-list/item.hbs
@@ -58,7 +58,7 @@
             <TranslationEdit::Helpers
               @permissions={{@permissions}}
               @project={{@project}}
-              @revisions={{@revisions}}
+              @languageSlug={{this.revisionSlug}}
               @prompts={{@prompts}}
               @rtl={{this.revisionTextDirRtl}}
               @text={{this.editText}}
diff --git a/webapp/app/templates/components/translation-edit.hbs b/webapp/app/templates/components/translation-edit.hbs
index e909f193f..6bb066c3b 100644
--- a/webapp/app/templates/components/translation-edit.hbs
+++ b/webapp/app/templates/components/translation-edit.hbs
@@ -21,8 +21,8 @@
         <div local-class='form-improve' data-rtl={{this.revisionTextDirRtl}}>
           <TranslationEdit::Helpers
             @permissions={{@permissions}}
+            @languageSlug={{this.revisionSlug}}
             @project={{@project}}
-            @revisions={{@revisions}}
             @prompts={{@prompts}}
             @rtl={{this.revisionTextDirRtl}}
             @text={{this.text}}
diff --git a/webapp/app/templates/components/translation-edit/helpers.hbs b/webapp/app/templates/components/translation-edit/helpers.hbs
index 9412bbe00..19a74a259 100644
--- a/webapp/app/templates/components/translation-edit/helpers.hbs
+++ b/webapp/app/templates/components/translation-edit/helpers.hbs
@@ -4,7 +4,7 @@
       @rtl={{@rtl}}
       @project={{@project}}
       @text={{@text}}
-      @languages={{this.machineTranslationLanguages}}
+      @languageSlug={{@languageSlug}}
       @onUpdatingText={{@onUpdatingText}}
       @onUpdateText={{@onUpdateText}}
     />
diff --git a/webapp/app/templates/components/translation-editions-list/item.hbs b/webapp/app/templates/components/translation-editions-list/item.hbs
index d3106ff41..aeebbd3c4 100644
--- a/webapp/app/templates/components/translation-editions-list/item.hbs
+++ b/webapp/app/templates/components/translation-editions-list/item.hbs
@@ -61,9 +61,9 @@
           {{#unless @translation.isRemoved}}
             <div local-class='form-helpers'>
               <TranslationEdit::Helpers
+                @languageSlug={{this.revisionSlug}}
                 @permissions={{@permissions}}
                 @project={{@project}}
-                @revisions={{@revisions}}
                 @prompts={{@prompts}}
                 @rtl={{this.revisionTextDirRtl}}
                 @text={{this.editText}}
diff --git a/webapp/app/templates/components/translations-list/item.hbs b/webapp/app/templates/components/translations-list/item.hbs
index b480b09a0..1359e4b54 100644
--- a/webapp/app/templates/components/translations-list/item.hbs
+++ b/webapp/app/templates/components/translations-list/item.hbs
@@ -103,7 +103,7 @@
                 <TranslationEdit::Helpers
                   @permissions={{@permissions}}
                   @project={{@project}}
-                  @revisions={{@revisions}}
+                  @languageSlug={{this.revisionSlug}}
                   @prompts={{@prompts}}
                   @rtl={{this.revisionTextDirRtl}}
                   @text={{this.editText}}
diff --git a/webapp/app/templates/logged-in/project/revision/translations.hbs b/webapp/app/templates/logged-in/project/revision/translations.hbs
index 11c83c14c..cd7f90758 100644
--- a/webapp/app/templates/logged-in/project/revision/translations.hbs
+++ b/webapp/app/templates/logged-in/project/revision/translations.hbs
@@ -33,7 +33,6 @@
     @versions={{this.model.project.versions.entries}}
     @project={{this.model.project}}
     @prompts={{this.model.prompts}}
-    @revisions={{this.revisions}}
     @permissions={{this.permissions}}
     @translations={{this.model.translations.entries}}
     @withAdvancedFilters={{this.withAdvancedFilters}}
diff --git a/webapp/app/templates/logged-in/project/translation/index.hbs b/webapp/app/templates/logged-in/project/translation/index.hbs
index beb5bcb65..257ff046e 100644
--- a/webapp/app/templates/logged-in/project/translation/index.hbs
+++ b/webapp/app/templates/logged-in/project/translation/index.hbs
@@ -16,7 +16,6 @@
         <RelatedTranslationsList
           @project={{this.model.project}}
           @permissions={{this.permissions}}
-          @revisions={{this.model.revisions}}
           @prompts={{this.model.prompts}}
           @translations={{this.model.relatedTranslations}}
           @onUpdateText={{fn this.updateTranslation}}