Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you have a plan to add lazy load to the widget in the future? #2

Open
tranhuudang opened this issue Oct 9, 2022 · 4 comments
Open

Comments

@tranhuudang
Copy link

I think loading speed is acceptable with those pdfs that have less than 30 pages. The higher the page count is, the slower it gets. I myself try to open a 200 pages document and it slows down my phone dramatically and obviously took a long time to finish.
So I thinking about lazy load solution for the list thumbnails, and I can see in the code that it is possible to add this useful function to your widget.

@mirkancal
Copy link
Owner

I'll check what we can do.

@tranhuudang
Copy link
Author

I did it in my branch, I vastly changed the way it builds the thumbnail list. I'm new to Flutter, so I'm not sure if it is the best practice to do it. But it works well as it is expected.

@mirkancal
Copy link
Owner

@tranhuudang no problem, just open a PR so I can check.

@mirkancal
Copy link
Owner

Added caching and updated the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants