Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for basic auth #2

Open
spiffzilla opened this issue Dec 20, 2017 · 4 comments
Open

Add support for basic auth #2

spiffzilla opened this issue Dec 20, 2017 · 4 comments
Assignees

Comments

@spiffzilla
Copy link
Contributor

When Elasticsearch are behind a basic auth login the plugin wont work.
Have tried do use plugin with a ES behind an Nginx proxy.

@misiupajor
Copy link
Owner

Thanks for the input @spiffzilla and you are indeed correct that it will not work as intended when basic auth is available. There is fundamental functionalities for supporting basic auth within the plugin, so I consider this an easy fix. I'll implement during the day and revert back.

@misiupajor misiupajor self-assigned this Dec 20, 2017
@spiffzilla
Copy link
Contributor Author

Great, I assume it will be argument controlled behaviour of the http auth functionality
.

@misiupajor
Copy link
Owner

Yes I think that would be the best approach, but I will make the arguments optional. If they are defined then basic auth is assumed

@misiupajor
Copy link
Owner

This is taking a bit longer than expected, but it's in the works. I'll ping you when I've fixed this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants