You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some environment variables like SLACK_ACCESS_TOKEN are not useful for bot_local.py, so we should only assert them when the Slack bot is starting.
Also, we should consider finer grained verification of environment variables at the command level. For example release does not require PYPI_USERNAME at all, and publish may or may not require PYPI_USERNAME depending on whether it's a python or npm release. I think it's fine to validate all of these variables on boot for Doof but it makes simple commands difficult for bot_local.py
The text was updated successfully, but these errors were encountered:
Currently we assert the presence of these variables:
Some environment variables like
SLACK_ACCESS_TOKEN
are not useful forbot_local.py
, so we should only assert them when the Slack bot is starting.Also, we should consider finer grained verification of environment variables at the command level. For example
release
does not requirePYPI_USERNAME
at all, andpublish
may or may not requirePYPI_USERNAME
depending on whether it's a python or npm release. I think it's fine to validate all of these variables on boot for Doof but it makes simple commands difficult forbot_local.py
The text was updated successfully, but these errors were encountered: