Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of required environment variables for bot_local.py #289

Open
noisecapella opened this issue Jan 4, 2021 · 0 comments
Open

Comments

@noisecapella
Copy link

Currently we assert the presence of these variables:

    'SLACK_ACCESS_TOKEN',
    'BOT_ACCESS_TOKEN',
    'GITHUB_ACCESS_TOKEN',
    'NPM_TOKEN',
    'SLACK_SECRET',
    'TIMEZONE',
    'PORT',
    'PYPI_USERNAME',
    'PYPI_PASSWORD',
    'PYPITEST_USERNAME',
    'PYPITEST_PASSWORD',

Some environment variables like SLACK_ACCESS_TOKEN are not useful for bot_local.py, so we should only assert them when the Slack bot is starting.

Also, we should consider finer grained verification of environment variables at the command level. For example release does not require PYPI_USERNAME at all, and publish may or may not require PYPI_USERNAME depending on whether it's a python or npm release. I think it's fine to validate all of these variables on boot for Doof but it makes simple commands difficult for bot_local.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant