Skip to content

Commit e445681

Browse files
committed
Simplify some more stuff here, don't kill session if it was established outside the API gateway
1 parent 7fdd9b1 commit e445681

File tree

1 file changed

+11
-14
lines changed

1 file changed

+11
-14
lines changed

unified_ecommerce/middleware.py

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -31,23 +31,20 @@ def process_request(self, request):
3131
logout(request)
3232
return
3333

34-
if request.user.is_authenticated:
35-
# The user is authenticated but like the RemoteUserMiddleware we
36-
# should now check and make sure the user APISIX is passing is
37-
# the same user.
34+
if apisix_user:
35+
if request.user.is_authenticated and request.user != apisix_user:
36+
# The user is authenticated, but doesn't match the user we got
37+
# from APISIX. So, log them out so the APISIX user takes
38+
# precedence.
3839

39-
if request.user != apisix_user:
4040
logout(request)
4141

42-
return
43-
44-
if not apisix_user:
45-
logout(request)
46-
47-
return
48-
49-
request.user = apisix_user
50-
login(request, apisix_user, backend="django.contrib.auth.backends.ModelBackend")
42+
request.user = apisix_user
43+
login(
44+
request,
45+
apisix_user,
46+
backend="django.contrib.auth.backends.ModelBackend",
47+
)
5148

5249
return
5350

0 commit comments

Comments
 (0)