-
First of all, thanks for creating and sharing nice template engines such as Jinja2 and MiniJinja! Why wrapping_add is used for integer addition? minijinja/minijinja/src/value/ops.rs Line 183 in edbaf59 I noticed checked version of operation like checked_sub or checked_mul are used for other operations. One of the reason I am asking this is since I am porting MiniJinja to Go and I would like to it to be compatible as MiniJinja as possible. https://github.com/hnakamur/mjingo/blob/b36cb7d5788c5aab21024a88bccd4f35c4271e4c/ops.go#L366-L377 But I am wondering is it really correct or maybe checked_add should be used instead. |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
An oversight. I will change this to checked which is more in line with the behavior of other operations. Changing in #350 |
Beta Was this translation helpful? Give feedback.
An oversight. I will change this to checked which is more in line with the behavior of other operations.
Changing in #350