Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build:icons script of components package fails #784

Closed
TimAufdemKampe opened this issue Sep 25, 2024 · 3 comments
Closed

build:icons script of components package fails #784

TimAufdemKampe opened this issue Sep 25, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@TimAufdemKampe
Copy link
Contributor

The build:icons script fails with an error.
Bildschirmfoto 2024-09-25 um 14 42 51

@TimAufdemKampe TimAufdemKampe added the bug Something isn't working label Sep 25, 2024
@TimAufdemKampe TimAufdemKampe self-assigned this Sep 25, 2024
@maaaathis
Copy link
Contributor

maaaathis commented Sep 25, 2024

Which nodejs version are you using @TimAufdemKampe ?

It works for me with nodejs 20.17.0. We need methods here that are introduced with nodejs 20.11.0: https://nodejs.org/en/blog/release/v20.11.0 (nodejs/node#48740)

@TimAufdemKampe
Copy link
Contributor Author

Which nodejs version are you using @TimAufdemKampe ?

It works for me with nodejs 20.17.0. We need methods here that are introduced with nodejs 20.11.0: https://nodejs.org/en/blog/release/v20.11.0

Oh okay, i'm using Node version 20.9.0.
Version 20.17.0 works perfectly fine 👍

Should be require a node version by the engines property in the package.json? To prevent other contributors from getting the same problem. @mfal

@maaaathis
Copy link
Contributor

maaaathis commented Sep 25, 2024

Which nodejs version are you using @TimAufdemKampe ?
It works for me with nodejs 20.17.0. We need methods here that are introduced with nodejs 20.11.0: nodejs.org/en/blog/release/v20.11.0

Oh okay, i'm using Node version 20.9.0. Version 20.17.0 works perfectly fine 👍

Should be require a node version by the engines property in the package.json? To prevent other contributors from getting the same problem. @mfal

Is already set to >=20.11: https://github.com/mittwald/flow/blob/main/package.json#L9 :)

@maaaathis maaaathis closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants