Skip to content

Commit 734e134

Browse files
committed
Improve type definitions
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
1 parent b5dd80f commit 734e134

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

aqt/archives.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -451,11 +451,11 @@ def _get_archives_base(self, name, target_packages):
451451

452452
self._parse_update_xmls(update_xmls, target_packages)
453453

454-
def _download_update_xml(self, update_xml_path: str, silent=False) -> Optional[str]:
454+
def _download_update_xml(self, update_xml_path: str, silent: bool=False) -> Optional[str]:
455455
"""Hook for unit test."""
456456
if not Settings.ignore_hash:
457457
try:
458-
xml_hash = get_hash(update_xml_path, Settings.hash_algorithm, self.timeout)
458+
xml_hash: Optional[bytes] = get_hash(update_xml_path, Settings.hash_algorithm, self.timeout)
459459
except ChecksumDownloadFailure:
460460
if silent:
461461
return None
@@ -470,7 +470,7 @@ def _download_update_xml(self, update_xml_path: str, silent=False) -> Optional[s
470470
xml_hash = None
471471
return getUrl(posixpath.join(self.base, update_xml_path), self.timeout, xml_hash)
472472

473-
def _parse_update_xml(self, os_target_folder, update_xml_text, target_packages: Optional[ModuleToPackage]):
473+
def _parse_update_xml(self, os_target_folder: str, update_xml_text: str, target_packages: Optional[ModuleToPackage]) -> None:
474474
if not target_packages:
475475
target_packages = ModuleToPackage({})
476476
update_xml = Updates.fromstring(self.base, update_xml_text)
@@ -510,7 +510,7 @@ def _parse_update_xml(self, os_target_folder, update_xml_text, target_packages:
510510
)
511511
)
512512

513-
def _parse_update_xmls(self, update_xmls, target_packages: Optional[ModuleToPackage]):
513+
def _parse_update_xmls(self, update_xmls: list[UpdateXmls], target_packages: Optional[ModuleToPackage]) -> None:
514514
if not target_packages:
515515
target_packages = ModuleToPackage({})
516516
for update_xml in update_xmls:
@@ -701,7 +701,7 @@ def handle_missing_updates_xml(self, e: ArchiveDownloadError):
701701
def _get_archives(self):
702702
self._get_archives_base(self.tool_name, None)
703703

704-
def _parse_update_xml(self, os_target_folder, update_xml_text, *ignored):
704+
def _parse_update_xml(self, os_target_folder: str, update_xml_text: str, *ignored) -> None:
705705
update_xml = Updates.fromstring(self.base, update_xml_text)
706706
self._append_tool_update(os_target_folder, update_xml, self.arch, self.tool_version_str)
707707

0 commit comments

Comments
 (0)