Computing weather categories

[Spookyguy]

I implemented a feature to compute several weather categories from METAR data:

• ICAO (IMC, VMC), see ICAO Annex 2: Rules of the Air, Chapter 4: Visual Flight Rules
• FAA (LIFR, IFR, MVFR, VFR), see https://www.faasafety.gov/gslac/alc/libview_printerfriendly.aspx?id=9091
• Military (RED, AMB, YLO, GRN, WHT, BLU), see https://semarv.weebly.com/uploads/3/1/8/7/3187688/military_metar_codes_v1.5.pdf
• GAFOR (X, M2, M5, M6, M7, M8, D1, D3, D4, O, C), see https://www.dwd.de/SharedDocs/broschueren/DE/luftfahrt/gafor.pdf?__blob=publicationFile&v=7 (german)

I will create a pull request soon.

[Spookyguy]

I tried to create a pull request, but git threw an error message:

$ git push
remote: Permission to mivek/MetarParser.git denied to Spookyguy.
fatal: unable to access 'https://github.com/mivek/MetarParser.git/': The requested URL returned error: 403

Do I need to get authorized for the project first?

Sorry, but this is my first contribution to a github project.

[mivek]

Hello @Spookyguy

Thank you for your interest in the project.
Initially this project is only a METAR and TAF decoder. It parses the message and produces a human understandable output.
There is no computing so my first thought it that this should not be available in the project. It will depend on the complexity and the representation within the METAR object.

How exactly do you compute the weather categories ?

Regarding the git error:

You have to fork the project, so you have your own copy of it. Then, after pushing your branch you will be able to create a pull request toward this repository. You can read more information about the process here.

[Spookyguy]

Hi @mivek,

the code just categorizes the weather by ceiling and visibility. I created a pull request, where you can see how that works.

Would be great to have that feature in the library to respect SOC principle, but if you don't want it in your project, it is no problem to implement the algorithms in my own application instead.

[mivek]

Hello @Spookyguy

I will have a look at your PR this we.
Sorry for the delay