perf(serverHandler/page): evaluate context querystring only once

Author: marjune163

src/serverHandler/page.go

@@ -14,11 +14,16 @@ const typeFile = template.HTML("file")
 
 func updateSubItemsHtml(data *responseData) {
 	length := len(data.SubItems)
+	if length == 0 {
+		return
+	}
 	data.SubItemsHtml = make([]itemHtml, length)
 
+	dirSuffix := "/" + data.Context.QueryString()
+	fileSuffix := data.Context.FileQueryString()
+
 	for i, info := range data.SubItems {
 		name := info.Name()
-		urlEscapedName := tplUtil.FormatFileUrl(name)
 
 		var displayName template.HTML
 		var typ template.HTML
@@ -28,11 +33,11 @@ func updateSubItemsHtml(data *responseData) {
 		if info.IsDir() {
 			displayName = tplUtil.FormatFilename(name) + "/"
 			typ = typeDir
-			url = data.SubItemPrefix + urlEscapedName + "/" + data.Context.QueryString()
+			url = data.SubItemPrefix + tplUtil.FormatFileUrl(name) + dirSuffix
 		} else {
 			displayName = tplUtil.FormatFilename(name)
 			typ = typeFile
-			url = data.SubItemPrefix + urlEscapedName + data.Context.FileQueryString()
+			url = data.SubItemPrefix + tplUtil.FormatFileUrl(name) + fileSuffix
 			readableSize = tplUtil.FormatSize(info.Size())
 		}
 

src/serverHandler/pathContext.go

@@ -10,7 +10,7 @@ type pathContext struct {
 func (ctx pathContext) QueryString() string {
 	// ?downloadfile&sort=x/&
 	buffer := make([]byte, 1, 22)
-	buffer[0] = '?'
+	buffer[0] = '?' // 1 byte
 
 	switch {
 	case ctx.downloadfile:
@@ -29,16 +29,16 @@ func (ctx pathContext) QueryString() string {
 	return string(buffer)
 }
 
+func (ctx pathContext) QueryStringOfSort(sort string) string {
+	copiedCtx := ctx
+	copiedCtx.sort = &sort
+	return copiedCtx.QueryString()
+}
+
 func (ctx pathContext) FileQueryString() string {
 	if ctx.downloadfile {
 		return "?downloadfile"
 	}
 
 	return ""
 }
-
-func (ctx pathContext) QueryStringOfSort(sort string) string {
-	copiedCtx := ctx
-	copiedCtx.sort = &sort
-	return copiedCtx.QueryString()
-}