refactor(serverHandler): refine pre process handler

- move loggable check logic into pre process handler
- fork goroutine earlier, so assembling log data will not block
  outputting

Author: marjune163

src/serverHandler/log.go

@@ -16,22 +16,10 @@ type loggableResponseWriter struct {
 
 func (w loggableResponseWriter) WriteHeader(statusCode int) {
 	w.ResponseWriter.WriteHeader(statusCode)
-	logRequest(w.logger, w.request, statusCode)
-}
-
-func tryGetLoggableResponseWriter(w http.ResponseWriter, r *http.Request, logger *serverLog.Logger) http.ResponseWriter {
-	if logger.CanLogAccess() {
-		return loggableResponseWriter{w, r, logger}
-	} else {
-		return w
-	}
+	go logRequest(w.logger, w.request, statusCode)
 }
 
 func logRequest(logger *serverLog.Logger, r *http.Request, statusCode int) {
-	if !logger.CanLogAccess() {
-		return
-	}
-
 	code := strconv.Itoa(statusCode)
 
 	var unescapedUri []byte
@@ -60,7 +48,7 @@ func logRequest(logger *serverLog.Logger, r *http.Request, statusCode int) {
 	}
 	buf = append(buf, uri...)
 
-	go logger.LogAccess(buf)
+	logger.LogAccess(buf)
 }
 
 func (h *aliasHandler) logMutate(username, action, detail string, r *http.Request) {

src/serverHandler/preprocessHandler.go

@@ -14,7 +14,9 @@ type preprocessHandler struct {
 }
 
 func (pph preprocessHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
-	w = tryGetLoggableResponseWriter(w, r, pph.logger)
+	if pph.logger.CanLogAccess() {
+		w = loggableResponseWriter{w, r, pph.logger}
+	}
 	rw := serverCompress.NewResponseWriter(w, r)
 
 	if len(pph.preMiddlewares) > 0 {