refactor(serverHandler): returns new sub items slice instead of mutate pointer

Author: marjune163

src/serverHandler/responseData.go

@@ -121,11 +121,11 @@ func readdir(file *os.File, item os.FileInfo, visitFs bool) (subItems []os.FileI
 	return file.Readdir(0)
 }
 
-func (h *handler) mergeAlias(item os.FileInfo, rawRequestPath string, subItems *[]os.FileInfo) []error {
+func (h *handler) mergeAlias(rawRequestPath string, item os.FileInfo, subItems []os.FileInfo) ([]os.FileInfo, []error) {
 	errs := []error{}
 
 	if item == nil || !item.IsDir() {
-		return errs
+		return subItems, errs
 	}
 
 	for _, alias := range h.aliases {
@@ -178,20 +178,20 @@ func (h *handler) mergeAlias(item os.FileInfo, rawRequestPath string, subItems *
 		}
 
 		replaced := false
-		for i, subItem := range *subItems {
+		for i, subItem := range subItems {
 			if subItem.Name() == nextName {
-				(*subItems)[i] = aliasSubItem
+				subItems[i] = aliasSubItem
 				replaced = true
 				break
 			}
 		}
 
 		if !replaced {
-			*subItems = append(*subItems, aliasSubItem)
+			subItems = append(subItems, aliasSubItem)
 		}
 	}
 
-	return errs
+	return subItems, errs
 }
 
 func getSubItemPrefix(requestPath string, tailSlash bool) (subItemPrefix string) {
@@ -311,7 +311,7 @@ func (h *handler) getResponseData(r *http.Request) (data *responseData) {
 		status = http.StatusInternalServerError
 	}
 
-	_mergeErrs := h.mergeAlias(item, rawReqPath, &subInfos)
+	subInfos, _mergeErrs := h.mergeAlias(rawReqPath, item, subInfos)
 	if len(_mergeErrs) > 0 {
 		errs = append(errs, _mergeErrs...)
 		status = http.StatusInternalServerError