Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This register int16 needs to change to int32 pas per sungrow register protocol, but remain singed power #360

Open
RafAustralia opened this issue Oct 1, 2024 · 4 comments

Comments

@RafAustralia
Copy link
Contributor

The value int16 is incorrect, needs to be changed to 32 but there is a mistake in sungrow protocol which calls for it to be uint, that is a mistake, the final result should remain int32

  - name: Total backup power
    device_address: !secret sungrow_modbus_slave
    unique_id: sg_total_backup_power
    address: 5725 # reg 5726
    input_type: input
    data_type: int32 # as per sungrow register list
    precision: 1
    unit_of_measurement: W
    device_class: power
    state_class: measurement
    scale: 1
    scan_interval: 10

image

@mkaiser
Copy link
Owner

mkaiser commented Oct 1, 2024

Cannot test this (do not have any backup stuff working here). Can you make a PR?

@RafAustralia
Copy link
Contributor Author

I will do my best to get to make a PR:

Logic here is - if you see sensors above, 5724, 5725 etc. they are all to do with backup power and they are all signed.
Total Backup power should be also signed - pretty sure Sungrow confirmed it was a bad translation error.

@Gnarfoz
Copy link
Contributor

Gnarfoz commented Oct 2, 2024

This correction is also slated to be in the next Sungrow modbus register specification (1.1.5), according to the Sungrow Germany product management team.
I've requested the new version of the document but have not received it, yet. 😢

@RafAustralia
Copy link
Contributor Author

RafAustralia commented Oct 2, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants