Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meshing issues on demo inputs with commit 0d5ebca #231

Closed
mzucker opened this issue Jan 9, 2025 · 4 comments
Closed

Meshing issues on demo inputs with commit 0d5ebca #231

mzucker opened this issue Jan 9, 2025 · 4 comments

Comments

@mzucker
Copy link

mzucker commented Jan 9, 2025

Pulled commit 0d5ebca today and ran the demos:

cargo run --release --bin fidget-cli -- --input models/bear.vm mesh --eval jit --depth 7 --out bear_7.stl
cargo run --release --bin fidget-cli -- --input models/bear.vm mesh --eval jit --depth 8 --out bear_8.stl
cargo run --release --bin fidget-cli -- --input models/bear.vm mesh --eval jit --depth 9 --out bear_9.stl

All three of the files exhibit jagged points in MacOS Preview, as shown here:

image image image

When viewed in MeshLab, there are some apparent triangles with incorrect orientations:

image

These disappear if you select the "Double" option for back-face rendering:

image image

The colonnade demo input also produced "spikies" when run at depth 7:

cargo run --release --bin fidget-cli -- --input models/colonnade.vm mesh --eval jit --depth 7 --out colonnade_7.stl    
image

The spikies disappear when run at depth 8:

image

I didn't see any issues in MeshLab with incorrectly wound triangles with the colonnade demo.

Rust information: rustc 1.83.0 (90b35a623 2024-11-26)

System information: Mac OS Sonoma 14.7.2 (23H311) on a 13-inch 2020 MacBook Pro with 2 GHz Quad-Core Intel Core i5 processor.

Please let me know if you want me to upload STL outputs or provide any additional system info.

@mkeeter
Copy link
Owner

mkeeter commented Jan 9, 2025

Thanks! I'm hoping this is the same issue as #225, because that's a simpler model to investigate.

@Wulfsta
Copy link
Contributor

Wulfsta commented Jan 9, 2025

@mkeeter is it possible the back facing triangle issue is the same as #198?

@mkeeter mkeeter mentioned this issue Jan 11, 2025
mkeeter added a commit that referenced this issue Jan 11, 2025
This fixes the spikes of #231 and notch in #225

Unfortunately, it requires careful hand-tuning of parameters, so there
may still be cases that it doesn't handle.
@mkeeter
Copy link
Owner

mkeeter commented Jan 11, 2025

I think this is improved by #232. Meshing is sensitive to carefully selected tuning parameters, so I've tweaked them a little bit and no longer see the spikes.

@mkeeter mkeeter closed this as completed Jan 11, 2025
@mzucker
Copy link
Author

mzucker commented Jan 13, 2025

Spikes are indeed gone but there seem to remain some back-facing triangles, at least according to MeshLab:

image

Meshlab also reports issues with non-manifold edges/faces.

This is bear at depth 7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants