Idea diff not opening if files contain spaces

[mkutz]

When using the following configuration

defaultFileReviewerScript = idea diff "{receivedFile}" "{approvedFile}"

Idea's diff view does not open as expected if the received and/or approved filenames contain any spaces.

Ultimately this is a bug in the script generated by JetBrains Toolbox TBX-7783.

That script uses MacOS' open command, which doesn't seem to like quoted spaces in filenames.

E.g. while this works:

meld "path/to file/with spaces-received.txt""path/to file/with spaces-approved.txt"

These do not:

open -na "meld" --args "path/to file/with spaces-received.txt" "path/to file/with spaces-approved.txt"

open -na "meld" --args path/to\ file/with\ spaces-received.txt path/to\ file/with\ spaces-approved.txt

The latter works when using absolute paths.

open -na "meld" --args ~/Projects/path/to\ file/with\ spaces-received.txt ~/Projects/path/to\ file/with\ spaces-approved.txt

[mkutz]

The easiest way to make the above work, is to fix the idea script by replacing

# ...
  if [[ "$o" =~ " " ]]; then
    intellij_args+=("\"$o\"")
  else
    intellij_args+=("$o")
  fi
# ...

with

# ...
  intellij_args+=("$o")
# ...

Note that redoing this might be necessary after updating Idea.

[mkutz]

You can prevent the JetBrains Toolbox from overwriting the fix by making the file read-only.

chmod -w "$(which idea)"