Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force unit on component definitions #122

Open
jchavarri opened this issue Jan 25, 2022 · 0 comments
Open

Force unit on component definitions #122

jchavarri opened this issue Jan 25, 2022 · 0 comments
Labels
enhancement New feature or request ppx

Comments

@jchavarri
Copy link
Collaborator

The make function needs unit at the end, but currently ppx allows to pass functions without it. It should prob be compulsory to avoid confusion, and if it's missing return some error.

Related: #106 (comment).
@jchavarri jchavarri added ppx enhancement New feature or request good first issue Good for newcomers and removed good first issue Good for newcomers labels Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request ppx
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jchavarri