Skip to content

Commit 404b7d0

Browse files
Address review comments
1 parent 6a62fa6 commit 404b7d0

File tree

2 files changed

+27
-7
lines changed

2 files changed

+27
-7
lines changed

hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/debug/TestFindContainerKeys.java

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
import com.google.gson.Gson;
2020
import com.google.gson.GsonBuilder;
2121
import org.apache.hadoop.hdds.client.BlockID;
22+
import org.apache.hadoop.hdds.client.RatisReplicationConfig;
2223
import org.apache.hadoop.hdds.conf.OzoneConfiguration;
23-
import org.apache.hadoop.hdds.protocol.proto.HddsProtos;
2424
import org.apache.hadoop.hdds.utils.db.DBStore;
2525
import org.apache.hadoop.hdds.utils.db.DBStoreBuilder;
2626
import org.apache.hadoop.hdds.utils.db.Table;
@@ -32,6 +32,7 @@
3232
import org.apache.hadoop.ozone.om.helpers.OmDirectoryInfo;
3333
import org.apache.hadoop.ozone.om.helpers.OmKeyInfo;
3434
import org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfo;
35+
import org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfoGroup;
3536
import org.apache.hadoop.ozone.om.request.OMRequestTestUtils;
3637
import org.junit.jupiter.api.AfterEach;
3738
import org.junit.jupiter.api.BeforeEach;
@@ -50,6 +51,7 @@
5051
import java.util.Map;
5152

5253
import static java.nio.charset.StandardCharsets.UTF_8;
54+
import static org.apache.hadoop.hdds.protocol.proto.HddsProtos.ReplicationFactor.ONE;
5355
import static org.apache.hadoop.ozone.OzoneConsts.OM_KEY_PREFIX;
5456
import static org.apache.hadoop.ozone.om.OmMetadataManagerImpl.DIRECTORY_TABLE;
5557
import static org.apache.hadoop.ozone.om.OmMetadataManagerImpl.FILE_TABLE;
@@ -244,12 +246,12 @@ private static OmKeyInfo getOmKeyInfo(String volumeName, String bucketName,
244246
long objectId,
245247
long parentId) {
246248
return OMRequestTestUtils.createOmKeyInfo(volumeName, bucketName,
247-
keyName, HddsProtos.ReplicationType.STAND_ALONE,
248-
HddsProtos.ReplicationFactor.ONE, objectId, parentId, 1, 1, 1, false,
249-
new ArrayList<>(
250-
Collections.singletonList(
251-
new OmKeyLocationInfo.Builder().setBlockID(
252-
new BlockID(containerId, 1)).build())));
249+
keyName, RatisReplicationConfig.getInstance(ONE), objectId, parentId,
250+
new OmKeyLocationInfoGroup(0L, Collections.singletonList(
251+
new OmKeyLocationInfo.Builder()
252+
.setBlockID(new BlockID(containerId, 1))
253+
.build())))
254+
.build();
253255
}
254256

255257
}

hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/OMRequestTestUtils.java

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import org.apache.hadoop.conf.Configuration;
2929
import org.apache.hadoop.hdds.HddsUtils;
3030
import org.apache.hadoop.hdds.client.BlockID;
31+
import org.apache.hadoop.hdds.client.RatisReplicationConfig;
3132
import org.apache.hadoop.hdds.client.ReplicationConfig;
3233
import org.apache.hadoop.hdds.client.ReplicationConfigValidator;
3334
import org.apache.hadoop.hdds.conf.ConfigurationSource;
@@ -559,6 +560,23 @@ public static OmKeyInfo.Builder createOmKeyInfo(String volumeName, String bucket
559560
new OmKeyLocationInfoGroup(0L, new ArrayList<>(), false));
560561
}
561562

563+
public static OmKeyInfo.Builder createOmKeyInfo(String volumeName, String bucketName, String keyName,
564+
RatisReplicationConfig replicationConfig, long objectId,
565+
long parentId, OmKeyLocationInfoGroup omKeyLocationInfoGroup) {
566+
return new OmKeyInfo.Builder()
567+
.setVolumeName(volumeName)
568+
.setBucketName(bucketName)
569+
.setKeyName(keyName)
570+
.setFileName(OzoneFSUtils.getFileName(keyName))
571+
.setReplicationConfig(replicationConfig)
572+
.setParentObjectID(parentId)
573+
.setObjectID(objectId)
574+
.setUpdateID(0L)
575+
.setCreationTime(Time.now())
576+
.addOmKeyLocationInfoGroup(omKeyLocationInfoGroup)
577+
.setDataSize(1000L);
578+
}
579+
562580
/**
563581
* Create OmDirectoryInfo.
564582
*/

0 commit comments

Comments
 (0)