-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLCubes CI #942
base: master
Are you sure you want to change the base?
MLCubes CI #942
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #942 +/- ##
==========================================
- Coverage 92.00% 91.92% -0.08%
==========================================
Files 171 171
Lines 10006 10020 +14
==========================================
+ Hits 9206 9211 +5
- Misses 800 809 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (1)gandlfcpu These words are not needed and should be removedadopy tiffslide UplodedSome files were automatically ignored 🙈These sample patterns would exclude them:
You should consider excluding directory paths (e.g. You should consider adding them to:
File matching is via Perl regular expressions. To check these files, more of their words need to be in the dictionary than not. You can use To accept these unrecognized words as correct, update file exclusions, and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:mlcommons/GaNDLF.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/mlcommons/GaNDLF/actions/runs/12394698764/attempts/1'
OR To have the bot accept them for you, comment in the PR quoting the following line: Available 📚 dictionaries could cover words not in the 📘 dictionary
Consider adding them (in with:
extra_dictionaries: |
cspell:java/src/java-terms.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' Warnings (3)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See |
I have made a few updates here: https://github.com/sarthakpati/GaNDLF/tree/mlcubes-ci |
Fixes #ISSUE_NUMBER
Proposed Changes
Checklist
CONTRIBUTING
guide has been followed.typing
is used to provide type hints, including and not limited to usingOptional
if a variable has a pre-defined value).pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].logging
library is being used and noprint
statements are left.