Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User bug: missing secrets for private modellab files when running public benchmark #762

Open
bkorycki opened this issue Dec 18, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@bkorycki
Copy link
Contributor

Sachi reports an error when running the command poetry run modelbench benchmark -m 10 --plugin-dir plugins/localModel/ --sut local_sut

I was trying to run modelbench, I think there were some latest changes in the last couple of days. When I try to run a sample of the benchmark, I get this:

raise MissingSecretValues.combine(missing_secrets)
modelgauge.secret_values.MissingSecretValues: Missing the following secrets:
scope='modellab_files' key='token' instructions='Please ask MLCommons admin for permission.'

I hadn't seen this before, is this for the latest practice set?
i added a new plugin - to read a local model. and it works with the "poetry run modelgauge run-csv-items sample.csv --sut local_sut

@bkorycki bkorycki added the bug Something isn't working label Dec 18, 2024
@mayank-soni
Copy link

+1 for facing this same issue with just a default poetry run modelbench benchmark -m 10 as per the testing instructions on https://github.com/mlcommons/modelbench/blob/main/README.md

@bkorycki
Copy link
Contributor Author

bkorycki commented Jan 9, 2025

Hi @mayank-soni, this bug was actually resolved already. Can you confirm that you have the latest version of modelbench checked out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants