Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merged dataset should accept a list of strings #694

Open
FinchPowers opened this issue Sep 30, 2016 · 4 comments
Open

merged dataset should accept a list of strings #694

FinchPowers opened this issue Sep 30, 2016 · 4 comments

Comments

@FinchPowers
Copy link
Member

FinchPowers commented Sep 30, 2016

Blog post about MLDB Hacktoberfest 2016


To create a merged dataset, one must specify the dataset with objects containing the "id" key. Eg.:

{
    'type' : 'merged',
    'params' : {
        'datasets' : [{'id' : 'ds1'}, {'id', 'ds2'}]
    }
}

If would be convenient if the ids would also work directly. Eg.:

{
    'type' : 'merged',
    'params' : {
        'datasets' : ['ds1', 'ds2']
    }
}

Context

Task

@FinchPowers FinchPowers changed the title merged dataset should accept a lsit of strings merged dataset should accept a list of strings Sep 30, 2016
@nistath
Copy link

nistath commented Oct 12, 2016

I can work on this, provided that you can point me to the source code that does the merging at the moment.

@FinchPowers
Copy link
Member Author

Hi @nistath

  • builtin/merged_dataset.cc is the merged dataset struct.
  • here is the place where the "datasets" key is bound to MergedDatasetConfig::datasets.

@nistath
Copy link

nistath commented Oct 12, 2016

To work on top of your existing code, I'll need the method that parses the dataset objects from the json.

@FinchPowers
Copy link
Member Author

It should be here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants