Merge branch 'main' into dsuhinin/update-readme

Author: dsuhinin

conftest.py

@@ -34,11 +34,16 @@ def pytest_configure(config):
             "tests.store.tracking.test_sqlalchemy_store.test_log_batch_internal_error",
             "tests/override_test_sqlalchemy_store.py",
         ),
-        # This test uses monkeypatch.setenv which does not flow through to the
+        # This test uses monkeypatch.setenv which does not flow through to the Go side.
         (
             "tests.store.tracking.test_sqlalchemy_store.test_log_batch_params_max_length_value",
             "tests/override_test_sqlalchemy_store.py",
         ),
+        # This test uses monkeypatch.setenv which does not flow through to the Go side.
+        (
+            "tests.store.tracking.test_sqlalchemy_store.test_log_param_max_length_value",
+            "tests/override_test_sqlalchemy_store.py",
+        ),
         # This tests calls the store using invalid metric entity that cannot be converted
         # to its proto counterpart.
         # Example: entities.Metric("invalid_metric", None, (int(time.time() * 1000)), 0).to_proto()

magefiles/generate/endpoints.go

@@ -24,7 +24,7 @@ var ServiceInfoMap = map[string]ServiceGenerationInfo{
 			"deleteRun",
 			"restoreRun",
 			"logMetric",
-			// "logParam",
+			"logParam",
 			// "setExperimentTag",
 			// "setTag",
 			// "setTraceTag",

magefiles/generate/validations.go

@@ -7,6 +7,8 @@ var validations = map[string]string{
 	"SearchRuns_RunViewType":             "omitempty",
 	"SearchRuns_MaxResults":              "gt=0,max=50000",
 	"DeleteExperiment_ExperimentId":      "required,stringAsPositiveInteger",
+	"LogParam_Key":                       "required,max=250,validMetricParamOrTagName,pathIsUnique",
+	"LogParam_Value":                     "omitempty,truncate=6000",
 	"LogBatch_RunId":                     "required,runId",
 	"LogBatch_Params":                    "omitempty,uniqueParams,max=100,dive",
 	"LogBatch_Metrics":                   "max=1000,dive",

mlflow_go/store/tracking.py

@@ -19,6 +19,7 @@
     GetRun,
     LogBatch,
     LogMetric,
+    LogParam,
     RestoreExperiment,
     RestoreRun,
     SearchRuns,
@@ -165,6 +166,14 @@ def log_metric(self, run_id, metric):
         )
         self.service.call_endpoint(get_lib().TrackingServiceLogMetric, request)
 
+    def log_param(self, run_id, param):
+        request = LogParam(
+            run_id=run_id,
+            key=param.key,
+            value=param.value,
+        )
+        self.service.call_endpoint(get_lib().TrackingServiceLogParam, request)
+
 
 def TrackingStore(cls):
     return type(cls.__name__, (_TrackingStore, cls), {})

pkg/contract/service/tracking.g.go

@@ -4,19 +4,26 @@ import "github.com/mlflow/mlflow-go/pkg/protos"
 
 type Param struct {
 	Key   string
-	Value string
+	Value *string
 }
 
 func (p Param) ToProto() *protos.Param {
 	return &protos.Param{
 		Key:   &p.Key,
-		Value: &p.Value,
+		Value: p.Value,
 	}
 }
 
 func ParamFromProto(proto *protos.Param) *Param {
 	return &Param{
 		Key:   *proto.Key,
-		Value: *proto.Value,
+		Value: proto.Value,
+	}
+}
+
+func ParamFromLogMetricProtoInput(input *protos.LogParam) *Param {
+	return &Param{
+		Key:   input.GetKey(),
+		Value: input.Value,
 	}
 }

pkg/entities/param.go

@@ -18,3 +18,13 @@ func (ts TrackingService) LogMetric(
 
 	return &protos.LogMetric_Response{}, nil
 }
+
+func (ts TrackingService) LogParam(
+	ctx context.Context, input *protos.LogParam,
+) (*protos.LogParam_Response, *contract.Error) {
+	if err := ts.Store.LogParam(ctx, input.GetRunId(), entities.ParamFromLogMetricProtoInput(input)); err != nil {
+		return nil, err
+	}
+
+	return &protos.LogParam_Response{}, nil
+}