Add additional validation checks

Signed-off-by: nojaf <florian.verdonck@outlook.com>

Author: nojaf

magefiles/generate/validations.go

@@ -32,8 +32,9 @@ var validations = map[string]string{
 	"SetExperimentTag_ExperimentId":      "required",
 	"SetExperimentTag_Key":               "required,max=250,validMetricParamOrTagName",
 	"SetExperimentTag_Value":             "max=5000",
-	"LogInputs_RunId":                    "required",
+	"LogInputs_RunId":                    "required,runId",
 	"LogInputs_Datasets":                 "required",
+	"DatasetInput_Dataset":               "required",
 	"Dataset_Name":                       "required,max=500",
 	"Dataset_Digest":                     "required,max=36",
 	"Dataset_SourceType":                 "required",

pkg/tracking/service/inputs.go

@@ -11,6 +11,10 @@ import (
 func (ts TrackingService) LogInputs(
 	ctx context.Context, input *protos.LogInputs,
 ) (*protos.LogInputs_Response, *contract.Error) {
+	if len(input.GetDatasets()) == 0 {
+		return &protos.LogInputs_Response{}, nil
+	}
+
 	datasets := make([]*entities.DatasetInput, 0, len(input.GetDatasets()))
 	for _, d := range input.GetDatasets() {
 		datasets = append(datasets, entities.NewDatasetInputFromProto(d))

pkg/tracking/store/sql/inputs.go

@@ -2,13 +2,39 @@ package sql
 
 import (
 	"context"
+	"errors"
+	"fmt"
+
+	"gorm.io/gorm"
 
 	"github.com/mlflow/mlflow-go/pkg/contract"
 	"github.com/mlflow/mlflow-go/pkg/entities"
+	"github.com/mlflow/mlflow-go/pkg/protos"
 )
 
 func (store TrackingSQLStore) LogInputs(
 	ctx context.Context, runID string, datasets []*entities.DatasetInput,
 ) *contract.Error {
+	err := store.db.WithContext(ctx).Transaction(func(transaction *gorm.DB) error {
+		contractError := checkRunIsActive(transaction, runID)
+		if contractError != nil {
+			return contractError
+		}
+
+		return nil
+	})
+	if err != nil {
+		var contractError *contract.Error
+		if errors.As(err, &contractError) {
+			return contractError
+		}
+
+		return contract.NewErrorWith(
+			protos.ErrorCode_INTERNAL_ERROR,
+			fmt.Sprintf("log inputs transaction failed for %q", runID),
+			err,
+		)
+	}
+
 	return nil
 }