...

Author: be-marc

NEWS.md

@@ -1,10 +1,10 @@
 # mlr3fselect (development version)
 
-compatibility: mlr3 0.22.0
+* compatibility: mlr3 0.22.0
+* feat: Add internal tuning callback `mlr3fselect.internal_tuning`.
 
 # mlr3fselect 1.2.0
 
-* feat: Add internal tuning callback `mlr3fselect.internal_tuning`.
 * fix: Register mlr3fselect in the `mlr_reflections$loaded_packages` field.
 
 # mlr3fselect 1.1.1

R/mlr_callbacks.R

@@ -153,7 +153,7 @@ load_callback_one_se_rule = function() {
     label = "One Standard Error Rule Callback",
     man = "mlr3fselect::mlr3fselect.one_se_rule",
 
-    on_result = function(callback, context) {
+    on_optimization_end = function(callback, context) {
       archive = context$instance$archive
       data = as.data.table(archive)
       data[, "n_features" := map(get("features"), length)]
@@ -203,7 +203,7 @@ load_callback_internal_tuning = function() {
         callback$state$internal_search_space$aggr_internal_tuned_values(internal_tuned_values)
       })
 
-        data.table::set(context$aggregated_performance, j = "internal_tuned_values", value = list(internal_tuned_values))
+      data.table::set(context$aggregated_performance, j = "internal_tuned_values", value = list(internal_tuned_values))
     },
 
     on_optimization_end = function(callback, context) {