Fix [Table] Remove unnecessary class from table header (#2180)

pinis-gini-apps · ilan7empest · commit 73951e8683f2 · 2024-01-12T18:12:20.000+02:00
diff --git a/src/components/DetailsResults/DetailsResults.js b/src/components/DetailsResults/DetailsResults.js
@@ -65,7 +65,7 @@ const DetailsResults = ({ allowSortBy, defaultSortBy, defaultDirection, excludeS
                 onClick={isSortable ? () => sortTable(headerId) : null}
               >
                 <Tooltip template={<TextTooltipTemplate text={headerLabel} />}>
-                  <label className="sortable-header-label">
+                  <label className={isSortable? 'sortable-header-label': ''}>
                     <span className="data-ellipsis">{headerLabel}</span>
                     {isSortable && getSortingIcon(headerId)}
                   </label>
diff --git a/src/components/Table/TableHead.js b/src/components/Table/TableHead.js
@@ -61,7 +61,7 @@ const TableHead = React.forwardRef(
                 onClick={isSortable ? () => sortProps.sortTable(headerId) : null}
               >
                 <Tooltip template={<TextTooltipTemplate text={headerLabel} />}>
-                  <label className="sortable-header-label">
+                  <label className={isSortable? 'sortable-header-label': ''}>
                     <span className="data-ellipsis">{headerLabel}</span>
                     {isSortable && sortProps.getSortingIcon(headerId)}
                   </label>

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ const DetailsResults = ({ allowSortBy, defaultSortBy, defaultDirection, excludeS`
`65`	`65`	`onClick={isSortable ? () => sortTable(headerId) : null}`
`66`	`66`	`>`
`67`	`67`	`<Tooltip template={<TextTooltipTemplate text={headerLabel} />}>`
`68`		`- <label className="sortable-header-label">`
	`68`	`+ <label className={isSortable? 'sortable-header-label': ''}>`
`69`	`69`	`<span className="data-ellipsis">{headerLabel}</span>`
`70`	`70`	`{isSortable && getSortingIcon(headerId)}`
`71`	`71`	`</label>`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ const TableHead = React.forwardRef(`
`61`	`61`	`onClick={isSortable ? () => sortProps.sortTable(headerId) : null}`
`62`	`62`	`>`
`63`	`63`	`<Tooltip template={<TextTooltipTemplate text={headerLabel} />}>`
`64`		`- <label className="sortable-header-label">`
	`64`	`+ <label className={isSortable? 'sortable-header-label': ''}>`
`65`	`65`	`<span className="data-ellipsis">{headerLabel}</span>`
`66`	`66`	`{isSortable && sortProps.getSortingIcon(headerId)}`
`67`	`67`	`</label>`