From bbcf9efe7cf8664bdba47fa7e2b73ef473f58e16 Mon Sep 17 00:00:00 2001
From: ilan7empest <therecanbeonly1.1984@gmail.com>
Date: Fri, 17 Nov 2023 15:45:33 +0800
Subject: [PATCH 1/2] Fix [Feature Store] Capitalize the first letter of the
 sentence in the Schema description.

---
 .../FeatureSetsPanelSchemaView.js                 | 15 ++++++---------
 .../featureSetsPanelSchema.scss                   |  4 ++++
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/src/components/FeatureSetsPanel/FeatureSetsPanelSchema/FeatureSetsPanelSchemaView.js b/src/components/FeatureSetsPanel/FeatureSetsPanelSchema/FeatureSetsPanelSchemaView.js
index ff0b2db9d..6a313aaf0 100644
--- a/src/components/FeatureSetsPanel/FeatureSetsPanelSchema/FeatureSetsPanelSchemaView.js
+++ b/src/components/FeatureSetsPanel/FeatureSetsPanelSchema/FeatureSetsPanelSchemaView.js
@@ -40,8 +40,10 @@ const FeatureSetsPanelSchemaView = ({
       <FeatureSetsPanelSection title="Schema">
         <div className="schema__description">
           <span>
-            Each feature set must be associated with one or more index column.
-            when joining feature sets the entity is used as the key column.
+            Each feature set must be associated with one or more index column. When joining feature
+            sets, the entity is used as the key column.
+          </span>
+          <span>
             <a
               className="link"
               href="https://docs.mlrun.org/en/latest/feature-store/feature-sets.html"
@@ -75,14 +77,9 @@ const FeatureSetsPanelSchemaView = ({
             floatingLabel
             invalid={!validation.isTimestampKeyValid}
             label="Timestamp key"
-            onChange={timestamp_key =>
-              setData(state => ({ ...state, timestamp_key }))
-            }
+            onChange={timestamp_key => setData(state => ({ ...state, timestamp_key }))}
             onBlur={event => {
-              if (
-                featureStore.newFeatureSet.spec.timestamp_key !==
-                event.target.value
-              ) {
+              if (featureStore.newFeatureSet.spec.timestamp_key !== event.target.value) {
                 setNewFeatureSetSchemaTimestampKey(event.target.value)
               }
             }}
diff --git a/src/components/FeatureSetsPanel/FeatureSetsPanelSchema/featureSetsPanelSchema.scss b/src/components/FeatureSetsPanel/FeatureSetsPanelSchema/featureSetsPanelSchema.scss
index dc9d80593..653d25d9a 100644
--- a/src/components/FeatureSetsPanel/FeatureSetsPanelSchema/featureSetsPanelSchema.scss
+++ b/src/components/FeatureSetsPanel/FeatureSetsPanelSchema/featureSetsPanelSchema.scss
@@ -16,5 +16,9 @@
 
   &__description {
     margin-bottom: 10px;
+
+    & > *:first-child {
+      margin-right: 5px;
+    }
   }
 }

From aff897ab24adcb60557d387d7ce07a86669ae102 Mon Sep 17 00:00:00 2001
From: ilan7empest <therecanbeonly1.1984@gmail.com>
Date: Sat, 18 Nov 2023 14:21:57 +0800
Subject: [PATCH 2/2] fix by code review

---
 .../FeatureSetsPanelSchema/FeatureSetsPanelSchemaView.js      | 1 +
 .../FeatureSetsPanelSchema/featureSetsPanelSchema.scss        | 4 ----
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/components/FeatureSetsPanel/FeatureSetsPanelSchema/FeatureSetsPanelSchemaView.js b/src/components/FeatureSetsPanel/FeatureSetsPanelSchema/FeatureSetsPanelSchemaView.js
index 6a313aaf0..262de9887 100644
--- a/src/components/FeatureSetsPanel/FeatureSetsPanelSchema/FeatureSetsPanelSchemaView.js
+++ b/src/components/FeatureSetsPanel/FeatureSetsPanelSchema/FeatureSetsPanelSchemaView.js
@@ -44,6 +44,7 @@ const FeatureSetsPanelSchemaView = ({
             sets, the entity is used as the key column.
           </span>
           <span>
+            &nbsp;
             <a
               className="link"
               href="https://docs.mlrun.org/en/latest/feature-store/feature-sets.html"
diff --git a/src/components/FeatureSetsPanel/FeatureSetsPanelSchema/featureSetsPanelSchema.scss b/src/components/FeatureSetsPanel/FeatureSetsPanelSchema/featureSetsPanelSchema.scss
index 653d25d9a..dc9d80593 100644
--- a/src/components/FeatureSetsPanel/FeatureSetsPanelSchema/featureSetsPanelSchema.scss
+++ b/src/components/FeatureSetsPanel/FeatureSetsPanelSchema/featureSetsPanelSchema.scss
@@ -16,9 +16,5 @@
 
   &__description {
     margin-bottom: 10px;
-
-    & > *:first-child {
-      margin-right: 5px;
-    }
   }
 }