From 6e71871e335acf991be53ee3d64e9c01aae65d42 Mon Sep 17 00:00:00 2001
From: ilan7empest <therecanbeonly1.1984@gmail.com>
Date: Tue, 30 Jan 2024 13:47:01 +0200
Subject: [PATCH 1/3] Fix [Batch Run] Blank project screen after setting model
target path
---
src/common/TargetPath/targetPath.util.js | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/common/TargetPath/targetPath.util.js b/src/common/TargetPath/targetPath.util.js
index 5bf49c2d79..15171388f6 100644
--- a/src/common/TargetPath/targetPath.util.js
+++ b/src/common/TargetPath/targetPath.util.js
@@ -302,11 +302,10 @@ export const generateArtifactsReferencesList = artifacts => {
.sort((prevRef, nextRef) => {
const [prevRefIter, prevRefTree] = prevRef.id.split('@')
const [nextRefIter, nextRefTree] = nextRef.id.split('@')
-
if (prevRefTree === nextRefTree) {
- return prevRefIter.localeCompare(nextRefIter)
+ return prevRefIter && prevRefIter.localeCompare(nextRefIter)
} else {
- return prevRefTree.localeCompare(nextRefTree)
+ return prevRefTree && prevRefTree.localeCompare(nextRefTree)
}
})
From df9e7efc45012e0dc7eaedf7af3a957fd3666e66 Mon Sep 17 00:00:00 2001
From: ilan7empest <therecanbeonly1.1984@gmail.com>
Date: Tue, 30 Jan 2024 15:42:08 +0200
Subject: [PATCH 2/3] Fix by code review
---
src/common/TargetPath/targetPath.util.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/common/TargetPath/targetPath.util.js b/src/common/TargetPath/targetPath.util.js
index 15171388f6..686d141615 100644
--- a/src/common/TargetPath/targetPath.util.js
+++ b/src/common/TargetPath/targetPath.util.js
@@ -302,6 +302,7 @@ export const generateArtifactsReferencesList = artifacts => {
.sort((prevRef, nextRef) => {
const [prevRefIter, prevRefTree] = prevRef.id.split('@')
const [nextRefIter, nextRefTree] = nextRef.id.split('@')
+
if (prevRefTree === nextRefTree) {
return prevRefIter && prevRefIter.localeCompare(nextRefIter)
} else {
From c6aab7c2105eec325ea7808a10ac50f6ec9cde41 Mon Sep 17 00:00:00 2001
From: ilan7empest <therecanbeonly1.1984@gmail.com>
Date: Tue, 30 Jan 2024 16:48:06 +0200
Subject: [PATCH 3/3] Fix by code review
---
package.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package.json b/package.json
index 8ccc02f20b..3576a19096 100644
--- a/package.json
+++ b/package.json
@@ -24,7 +24,7 @@
"final-form-arrays": "^3.0.2",
"fs-extra": "^10.0.0",
"identity-obj-proxy": "^3.0.0",
- "iguazio.dashboard-react-controls": "1.8.4",
+ "iguazio.dashboard-react-controls": "1.8.5",
"is-wsl": "^1.1.0",
"js-base64": "^2.5.2",
"js-yaml": "^3.13.1",