Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces in machine name breaks Dropkick tasks #12

Open
mmooney opened this issue May 31, 2014 · 0 comments
Open

Spaces in machine name breaks Dropkick tasks #12

mmooney opened this issue May 31, 2014 · 0 comments

Comments

@mmooney
Copy link
Owner

mmooney commented May 31, 2014

If there is a space in the machine name (or anywhere else that would impact the local run path), it will break any tasks that call dropkick (dk.exe). This is because when the settings/deployment paths are passed into dk.exe, even if you wrap them in quotes, it will lose track of the quotes and garble the command line.

This is described here: chucknorris/dropkick#34. There was a PR submitted to fix it, but it seems like it still causes the issue (the PR added back double-quotes, but even passing double quotes down to underlying Magnum library doesn't solve the issue, Magnum still loses track of the double quotes).

Another possible solution is to force dk.exe to not use full paths, but use relative ones instead. This is possible, but kinda hacky. Ideally we can get dk.exe to handle the double quotes more cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant