From a650e872229fb51b2ef9d18b93b40a042f1c07cb Mon Sep 17 00:00:00 2001 From: Yi Lin Date: Tue, 16 Apr 2024 20:18:31 +1200 Subject: [PATCH] Fix ignores in merge check (#1117) We renamed CI tests in https://github.com/mmtk/mmtk-core/pull/1073, but forgot to rename them in the ignored list for the merge check. This PR fixes this. --- .github/workflows/merge-check.yml | 28 +++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/.github/workflows/merge-check.yml b/.github/workflows/merge-check.yml index 56dade26e8..796237e2fa 100644 --- a/.github/workflows/merge-check.yml +++ b/.github/workflows/merge-check.yml @@ -7,6 +7,28 @@ on: branches: - master +env: + # Ignore some actions for the merge check: + # - This action itself + # - Public API check, doc broken link check: we allow them to fail. + # - Minimal tests for stable Rust: we allow them to fail. + # - Extended binding tests: it may take long to run. We don't want to wait for them. + IGNORED_ACTIONS: | + [ + "ready-to-merge", + "check-broken-links-in-docs", + "check-public-api-changes", + "minimal-tests-core/x86_64-unknown-linux-gnu/stable", + "minimal-tests-core/i686-unknown-linux-gnu/stable", + "minimal-tests-core/x86_64-apple-darwin/stable", + "extended-tests-v8", + "extended-tests-jikesrvm", + "extended-tests-julia", + "extended-tests-openjdk", + "extended-tests-ruby (release)", + "extended-tests-ruby (debug)" + ] + jobs: ready-to-merge: runs-on: ubuntu-latest @@ -16,11 +38,7 @@ jobs: timeout-minutes: 120 uses: "WyriHaximus/github-action-wait-for-status@v1.8.0" with: - # Ignore some actions (based on what merge_group triggers): - # - this action - # - minimal tests for stable Rust (we allow them to fail) - # - binding tests (it may take long to run) - ignoreActions: "ready-to-merge,check-broken-links-in-docs,check-public-api-changes,minimal-tests-core/x86_64-unknown-linux-gnu/stable,minimal-tests-core/i686-unknown-linux-gnu/stable,minimal-tests-core/x86_64-apple-darwin/stable,v8-binding-test,openjdk-binding-test,jikesrvm-binding-test,julia-binding-test,ruby-binding-test (release),ruby-binding-test (debug)" + ignoreActions: "${{ join(fromJson(env.IGNORED_ACTIONS)) }}" # This action uses API. We have a quota of 1000 per hour. checkInterval: 600 env: