Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete TypeScript definitions - missing component exports #2

Open
karnoark opened this issue Dec 11, 2024 · 0 comments · May be fixed by #3
Open

Incomplete TypeScript definitions - missing component exports #2

karnoark opened this issue Dec 11, 2024 · 0 comments · May be fixed by #3

Comments

@karnoark
Copy link

The current type definitions in index.d.ts are incomplete, causing TypeScript errors when trying to use components. For example, when trying to import RatingInput:

import { RatingInput } from 'react-native-stock-star-rating';

This produces the error:
Module "react-native-stock-star-rating" has no exported member 'RatingInput'
The current type definitions only include the RatingProps interface but don't declare the actual component exports. I propose adding complete type declarations for all exported components including Rating, RatingInput, FilledStar, and EmptyStar.
I'm happy to submit a pull request with these improvements if this approach sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant