Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

Relation between MNE-binder and MNE-docker #9

Open
rob-luke opened this issue Jun 27, 2021 · 1 comment
Open

Relation between MNE-binder and MNE-docker #9

rob-luke opened this issue Jun 27, 2021 · 1 comment

Comments

@rob-luke
Copy link
Member

I would like to clarify the relationship between this repository and MNE-binder, and propose that this repository be refactored to rely on MNE-binder or be depreceated.

Currently both MNE-binder and MNE-docker contain Dockerfiles to run MNE-python via docker. This seems to be a dupliation of work. Instead I propose we do either:

  1. Keep both MNE-binder and MNE-docker. Release an image of MNE-docker (see Add action to push images to GitHub container repository  mne-docker#9), and build MNE-binder from that image.
  • Reduces duplicate code.
  • But this repo is then only adding the link to the notebooks.
  • Easier to find for people looking for binder (could be overcome by rewriting the MNE-docker readme).
  1. Depreceate MNE-binder. Use MNE-docker to build a binder image.
  • This will just add a single file to MNE-docker that links to the MNE notebooks

My vote is for 2. Any opinions/thoughts @agramfort @larsoner @wmvanvliet @bloyl ?

@wmvanvliet
Copy link
Contributor

I'm fine with depricating mne-binder in favor of mne-docker

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants