Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling in commands when startup fails #10

Open
garbagemule opened this issue Jul 5, 2021 · 0 comments
Open

Improve error handling in commands when startup fails #10

garbagemule opened this issue Jul 5, 2021 · 0 comments
Labels
good first issue Perfect for people new to the code base. type/enhancement New or improved feature.

Comments

@garbagemule
Copy link
Collaborator

A misconfiguration in the plugin or the chosen data store will result in an error somewhere in the startup process. Because the commands are set up before the stats store is initialized, the commands can still run even though the initialization fails (this is good, because it gives us a way to report issues inside the commands).

To test this out, try spinning up the plugin with an invalid store type like type: foo, then run a command like /ma global-stats.

All commands currently assume the stats store is non-null, and in the case of a failed initialization, that assumption is wrong. It would be a good idea to make the commands check for this and report some sort of generic No stats store configured. Check the server log for errors. error message.

@garbagemule garbagemule added type/enhancement New or improved feature. good first issue Perfect for people new to the code base. labels Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Perfect for people new to the code base. type/enhancement New or improved feature.
Projects
None yet
Development

No branches or pull requests

1 participant