Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table with tomograms #1

Open
tischi opened this issue Sep 10, 2020 · 10 comments
Open

Table with tomograms #1

tischi opened this issue Sep 10, 2020 · 10 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@tischi
Copy link
Contributor

tischi commented Sep 10, 2020

@constantinpape
If you think the label mask is too much of a hack, we can also think of another solution.
But maybe it actually turns out to even be a good general solution even for the PlateViewer...
I can't wrap my head around it right now. Maybe we just try and see what happens?

@tischi tischi added the enhancement New feature or request label Sep 10, 2020
@constantinpape
Copy link
Contributor

If you think the label mask is too much of a hack, we can also think of another solution.
But maybe it actually turns out to even be a good general solution even for the PlateViewer...
I can't wrap my head around it right now. Maybe we just try and see what happens?

I agree, let's just try it and see how we can improve it in the long run.
I think for whatever we come up with we can reuse the table in any case, because we will somehow need the bounding box and anchor information etc.

@constantinpape
Copy link
Contributor

constantinpape commented Sep 10, 2020

I have added the mock segmentation with tables for 3 of the datasets.
(There is some issue with the remaining one, but this should be easy to figure out with Yannick).

@tischi
Copy link
Contributor Author

tischi commented Jan 24, 2022

@constantinpape

image

I think the name of the uiGroup and "segmentation" is not very intuitive:

“position: em-tomogram-segmentation” as this is just the annotation of the images.

BTW: Could it be that the "new spec" branch still needs to be merged into main?

@tischi tischi added the bug Something isn't working label Jan 24, 2022
@constantinpape
Copy link
Contributor

I think the name of the uiGroup and "segmentation" is not very intuitive:

Sure, that's easy to fix; I can do that later.

@constantinpape
Copy link
Contributor

BTW: Could it be that the "new spec" branch still needs to be merged into main?

I am not sure about the differences between the two branches, will check it out later.

@tischi
Copy link
Contributor Author

tischi commented Jan 24, 2022

If you can, could you do it before lunch? I would like to demo this in a COMULIS meeting today...

@constantinpape
Copy link
Contributor

Sorry, I am still traveling to Heidelberg and the Bahn is misbehaving...
So I don't have so stable internet and can probably not do this now.

@tischi
Copy link
Contributor Author

tischi commented Jan 24, 2022

I think before 15:00 would still be fine.
Otherwise I can live with the current version.

@constantinpape
Copy link
Contributor

I had a quick look but the differences between the main branch and new-spec are a bit complicated and I am not quite sure which one is more up-to-date. I need to double check this while I can open the project in MoBIE, which is not possible with train WiFi...
Let's stick with the current version and I will have a look at this once I work on the corresponding figure for the paper.

@tischi
Copy link
Contributor Author

tischi commented Jan 24, 2022

OK!
spec-v2 seems more up to date for me.
I think master is still using a hack for the annotated image view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants