From 061b7d911bcbbedbbb160ff6d47c6b1b1a4653ae Mon Sep 17 00:00:00 2001 From: Dante Iozzo Date: Thu, 20 Aug 2020 16:24:53 -0400 Subject: [PATCH 1/2] Missed a few eth -> eth_GHP replacements --- scri/asymptotic_bondi_data/from_initial_values.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scri/asymptotic_bondi_data/from_initial_values.py b/scri/asymptotic_bondi_data/from_initial_values.py index 2188e37c..1d1041b4 100644 --- a/scri/asymptotic_bondi_data/from_initial_values.py +++ b/scri/asymptotic_bondi_data/from_initial_values.py @@ -103,7 +103,7 @@ def asany_atleast2d_complex(a): # ψ₂ = ∫ (-ðψ₃ + σψ₄) du ψ2_0 = ( ModesTimeSeries(psi2, u, spin_weight=0, multiplication_truncator=max).real - - 1j * (σ_0.bar.eth.eth + σ_0 * σ_1.bar).imag + - 1j * (σ_0.bar.eth_GHP.eth_GHP + σ_0 * σ_1.bar).imag ) ψ2_1 = σ_0 * ψ4_0 + ð(ψ3_0) ψ2_2 = (σ_1 * ψ4_0 + ð(ψ3_1)) / 2 @@ -134,7 +134,7 @@ def adjust_psi2_imaginary_part(psi2, abd): sigma_bar_dot_initial = abd.sigma.bar.dot[..., 0, :] return ( ModesTimeSeries(psi2, abd.time, spin_weight=0).real - - 1j * (sigma_initial.bar.eth.eth + sigma_initial * sigma_bar_dot_initial).imag + - 1j * (sigma_initial.bar.eth_GHP.eth_GHP + sigma_initial * sigma_bar_dot_initial).imag ) abd.sigma = sigma0 From 718880fa91e4a5edb44a26c1850781e3c146ab16 Mon Sep 17 00:00:00 2001 From: Dante Iozzo Date: Thu, 20 Aug 2020 16:25:11 -0400 Subject: [PATCH 2/2] Fix signs in comments --- scri/asymptotic_bondi_data/from_initial_values.py | 2 +- tests/test_abd_ivp.py | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/scri/asymptotic_bondi_data/from_initial_values.py b/scri/asymptotic_bondi_data/from_initial_values.py index 1d1041b4..2760c107 100644 --- a/scri/asymptotic_bondi_data/from_initial_values.py +++ b/scri/asymptotic_bondi_data/from_initial_values.py @@ -100,7 +100,7 @@ def asany_atleast2d_complex(a): ψ3_0 = -ð(conjugate(σ_1)) ψ3_1 = -2 * ð(conjugate(σ_2)) abd.psi3 = u * ψ3_1 + ψ3_0 - # ψ₂ = ∫ (-ðψ₃ + σψ₄) du + # ψ₂ = ∫ (ðψ₃ + σψ₄) du ψ2_0 = ( ModesTimeSeries(psi2, u, spin_weight=0, multiplication_truncator=max).real - 1j * (σ_0.bar.eth_GHP.eth_GHP + σ_0 * σ_1.bar).imag diff --git a/tests/test_abd_ivp.py b/tests/test_abd_ivp.py index 44afefa5..bc423a05 100644 --- a/tests/test_abd_ivp.py +++ b/tests/test_abd_ivp.py @@ -55,7 +55,7 @@ def validator(abd): def test1(): """Add ℓ=0 term to ψ₂ intial value - Ensures that first terms of ψ̇₁u = -ðψ₂ + 2σψ₃ and ψ̇₀ = -ðψ₁ + 3σψ₂ don't get excited + Ensures that first terms of ψ̇₁u = ðψ₂ + 2σψ₃ and ψ̇₀ = ðψ₁ + 3σψ₂ don't get excited """ @@ -85,7 +85,7 @@ def validator(abd): def test2(): """Add ℓ=1 term to ψ₂ intial value - Checks first term of ψ̇₁ = -ðψ₂ + 2σψ₃ + Checks first term of ψ̇₁ = ðψ₂ + 2σψ₃ """ @@ -115,7 +115,7 @@ def validator(abd): def test3(): """Add ℓ=2 term to ψ₂ intial value - Checks first term of ψ̇₀ = -ðψ₁ + 3σψ₂ + Checks first term of ψ̇₀ = ðψ₁ + 3σψ₂ """ @@ -147,7 +147,7 @@ def validator(abd): def test4(): """Add nonzero constant term to σ - Checks first term of ψ̇₁ = -ðψ₂ + 2σψ₃ and second term of ψ̇₀ = -ðψ₁ + 3σψ₂ + Checks first term of ψ̇₁ = ðψ₂ + 2σψ₃ and second term of ψ̇₀ = ðψ₁ + 3σψ₂ After satisfaction of the reality condition on the mass aspect, ψ₂ has nonzero modes in {(0, 0), (2, -2), (2, 2)}, so ψ₁ should have nonzero modes in {(2, -2), (2, 2)}. Here, @@ -182,7 +182,7 @@ def validator(abd): def test5(): """Add nonzero ℓ=2 term to σ̇ - Checks second term of ψ̇₁ = -ðψ₂ + 2σψ₃ + Checks second term of ψ̇₁ = ðψ₂ + 2σψ₃ """ @@ -212,7 +212,7 @@ def validator(abd): def test6(): """Add nonzero ℓ=2 term to σ̈ - Checks second term of ψ̇₂ = -ðψ₃ + σψ₄ + Checks second term of ψ̇₂ = ðψ₃ + σψ₄ """