Skip to content

Conversation

@rjsocha
Copy link

@rjsocha rjsocha commented Dec 7, 2025

Reference: #6177, https://github.com/moby/buildkit/blob/master/docs/buildkitd.toml.md

This PR adds support to inherit registry options as defaults for mirrors without explicit config.

Before:

[registry."docker.io"]
  mirrors = ["mirror1.example.dev", "mirror2.example.dev"]

[registry."mirror1.example.dev"]
  http = true

[registry."mirror2.example.dev"]
  http = true

After:

[registry."docker.io"]
  mirrors = ["mirror.example.dev", "mirror2.example.dev"]
  http = true

Reference: #6177, https://github.com/moby/buildkit/blob/master/docs/buildkitd.toml.md

This PR adds support to inherit registry options as defaults for mirrors without explicit config.

Before:
```
[registry."docker.io"]
  mirrors = ["mirror1.example.dev", "mirror2.example.dev"]

[registry."mirror1.example.dev"]
  http = true

[registry."mirror2.example.dev"]
  http = true
```

After:
```
[registry."docker.io"]
  mirrors = ["mirror.example.dev", "mirror2.example.dev"]
  http = true
```
@tonistiigi
Copy link
Member

I don't think we should do it. Better to leave mirrors secure by default and users can always reconfigure them if needed. If you like, you can update the docs to make it clearer that mirrors require their own custom configuration.

@rjsocha
Copy link
Author

rjsocha commented Dec 9, 2025

Thanks for the clarification. A note in the docs would definitely help others configure this correctly. Feel free to close this PR.

@rjsocha rjsocha closed this by deleting the head repository Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants