-
Notifications
You must be signed in to change notification settings - Fork 577
Open
Description
The generator has few patterns that hurt SG incrementality.
- Having
Compilationin the source output step (the last step) in the generator pipeline. That effectively means this step will always be running and it kinda acts asISourceGenerator. - Having
IMethodSymbolin the pipeline models (inMethodToGenerate) - Having syntax nodes in pipeline models (in
MethodToGenerate) - Attempting to produce diagnostics in generator. While the API exists, I do believe it's discouraged, and a separate diagnostic analyzer is more preferred.
XmlDocumentationis unlikely to be comparable. It hasDictionary<string, string>, but if two different dictionary instances are compared, the result will be false even if they contain the same key-value pairs.
IMO, point 4 is best addressed first, as it might already simplify the implementation and make the rest easier to fix.
cc @stephentoub
eiriktsarpalis
Metadata
Metadata
Assignees
Labels
No labels