Skip to content

[Server] Lower log level on failing tool calls #157

@chr-hertel

Description

@chr-hertel

Hi @chr-hertel , sorry, but I didn't have time to finish the PR.

At a quick glance it looks like a sufficient solution, the only question is whether it's really necessary to log errors from ToolCallException. In my experience, they were never needed, and in the worst case you can log directly in the McpTool method.

If I take an example where the AI/human calls divideNumbers with $b as 0 and McpTool responds that you can't divide by zero, I would expect it to handle that and provide a different number or ask for a different one. Otherwise, I would end up with Sentry full of logs that I can’t and don’t want to deal with, because it’s not an application error.

Logging is probably fine during debugging, but I would keep it at most at debug/info severity.

Thanks for mention.

Originally posted by @MartkCz in #73 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions