Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: warn on unrecognized units #2008

Open
wpbonelli opened this issue Nov 17, 2023 · 1 comment
Open

feature: warn on unrecognized units #2008

wpbonelli opened this issue Nov 17, 2023 · 1 comment
Assignees
Milestone

Comments

@wpbonelli
Copy link
Member

wpbonelli commented Nov 17, 2023

Suggested in MODFLOW-USGS/modflow6#1452

@wpbonelli wpbonelli added this to the 3.5.0 milestone Nov 17, 2023
@wpbonelli wpbonelli self-assigned this Nov 17, 2023
@wpbonelli wpbonelli modified the milestones: 3.5.0, 3.6.0 Nov 18, 2023
@wpbonelli
Copy link
Member Author

wpbonelli commented Nov 18, 2023

This seems more involved than anticipated — when length_units are passed to e.g. flopy.mf6.ModflowGwfdis they are first set on the discretization instance via generic mfdata mechanisms before making their way into a Grid, which parses the value and attempts to assign a recognized unit. While Grid recognizes "cm" as "centimeters", this info is not passed back to the discretization during model initialization or when write_simulation() is called.

Intercepting somewhere and warning on unrecognized length units is possible but it seems better to consider refactoring init- and/or write-time logic so input files reflect everything flopy knows about the grid discretization

@wpbonelli wpbonelli modified the milestones: 3.6.0, 3.7.0 Mar 2, 2024
@wpbonelli wpbonelli modified the milestones: 3.7.0, 3.8.0 May 23, 2024
@wpbonelli wpbonelli modified the milestones: 3.8.0, 3.9.0 Aug 5, 2024
@wpbonelli wpbonelli modified the milestones: 3.9, 4.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant