You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This concerns all class names prefixed with MF or Mf.
While poking around, I tried using MFSimulationList class, but that apparently doesn't exist because it is instead called MfSimulationList which I thought is a bit unexpected. So I checked to see where MF or Mf is used as a prefix and it seems like there is a pattern, but just almost.
Within flopy/mf6, everything is using MF (e.g. MFDataException, MFBlock, MFTransient, etc.), except for MfGrdFile, MfSimulationList and Mf6Splitter. Elsewhere, Mf is used (e.g. as found in flopy/mfusg and flopy/utils: MfUsg, MfList, Mf6Obs, etc.).
My questions:
First of all, is this inconsistent at all, or did I maybe just miss a different intended pattern?
If it's indeed inconsistent and if this is worth a clean-up, can I simply keep all the mf-prefixed classes in flopy/mf6 with MF?
If not, how exactly do we go about this?
The text was updated successfully, but these errors were encountered:
I think the difference in patterning comes from multiple people developing the code and not specifying a formal convention for MF vs. Mf prefix. I'm personally partial to Mf over MF, but I'd like to hear what others think prior to making any changes to the mf6 naming conventions.
@wpbonelli, I like your idea to remove the prefix. We might even build on that further for the mf6 packages. We could probably rethink the name space to better accommodate ModflowGwfevt, for example.
This concerns all class names prefixed with
MF
orMf
.While poking around, I tried using
MFSimulationList
class, but that apparently doesn't exist because it is instead calledMfSimulationList
which I thought is a bit unexpected. So I checked to see whereMF
orMf
is used as a prefix and it seems like there is a pattern, but just almost.Within
flopy/mf6
, everything is usingMF
(e.g.MFDataException
,MFBlock
,MFTransient
, etc.), except forMfGrdFile
,MfSimulationList
andMf6Splitter
. Elsewhere,Mf
is used (e.g. as found inflopy/mfusg
andflopy/utils
:MfUsg
,MfList
,Mf6Obs
, etc.).My questions:
flopy/mf6
withMF
?The text was updated successfully, but these errors were encountered: