WIP add stack overflow check in yield

Author: salkinium

examples/generic/fiber_overflow/main.cpp

@@ -0,0 +1,49 @@
+/*
+ * Copyright (c) 2024, Niklas Hauser
+ *
+ * This file is part of the modm project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+// ----------------------------------------------------------------------------
+
+#include <modm/board.hpp>
+#include <modm/processing.hpp>
+
+using namespace Board;
+using namespace std::chrono_literals;
+
+// modm::Fiber<> blinky([]
+// {
+// 	while(1)
+// 	{
+// 		Board::Leds::toggle();
+// 		modm::this_fiber::sleep_for(0.5s);
+// 	}
+// });
+
+modm::Fiber<> bad_fiber([]
+{
+
+	MODM_LOG_INFO << "\nReboot!\nPush the button to overflow the stack!" << modm::endl;
+
+	while(1)
+	{
+		// cause stack overflow on button push
+		if (Button::read()) asm volatile ("push {r0-r7}");
+		modm::this_fiber::yield();
+	}
+});
+
+int
+main()
+{
+	Board::initialize();
+	Board::Leds::setOutput();
+
+	modm::fiber::Scheduler::run();
+
+	return 0;
+}

examples/generic/fiber_overflow/project.xml

@@ -0,0 +1,11 @@
+<library>
+  <!-- <extends>modm:nucleo-u575zi-q</extends> -->
+  <extends>modm:nucleo-g071rb</extends>
+  <options>
+    <option name="modm:build:build.path">../../../build/generic/fiber_overflow</option>
+  </options>
+  <modules>
+    <module>modm:build:scons</module>
+    <module>modm:processing:fiber</module>
+  </modules>
+</library>

examples/nucleo_u575zi-q/fiber_overflow/project.xml

@@ -64,7 +64,7 @@ modm_context_reset(modm_context_t *ctx);
  * Switches control from the main context to the fiber context. This initializes
  * the hardware and then jumps from the caller context into the `to` fiber.
  */
-void
+uintptr_t
 modm_context_start(modm_context_t *to);
 
 /**
@@ -80,7 +80,7 @@ modm_context_jump(modm_context_t *from, modm_context_t *to) asm("modm_context_ju
  * `modm_context_start()` function.
  */
 void modm_noreturn
-modm_context_end();
+modm_context_end(uintptr_t retval);
 
 /**
  * Zeros the register file and watermarks the rest of the stack.

src/modm/processing/fiber/context.h

@@ -142,7 +142,7 @@ modm_context_stack_usage(const modm_context_t *ctx)
 bool
 modm_context_stack_overflow(const modm_context_t *ctx)
 {
-	return *ctx->bottom != StackWatermark;
+	return ctx->sp < ctx->bottom or *ctx->bottom != StackWatermark;
 }
 
 #define MODM_PUSH_CONTEXT() \
@@ -173,7 +173,7 @@ modm_context_stack_overflow(const modm_context_t *ctx)
 		"pop {r4-r11, pc}	\n\t"
 %% endif
 %#
-void modm_naked
+uintptr_t modm_naked
 modm_context_start(modm_context_t*)
 {
 	asm volatile
@@ -211,41 +211,57 @@ modm_context_jump(modm_context_t*, modm_context_t*)
 	(
 		MODM_PUSH_CONTEXT()
 %#
+%% if not with_psplim
+		"ldr r3, [r0, #4]		\n\t"	// Load from->bottom
+%% endif
 %% if is_cm0
-		"mov r2,  sp		\n\t"
-		"str r2, [r0]		\n\t"	// Store the SP in from->sp
+		"mov r2,  sp			\n\t"
+		"str r2, [r0]			\n\t"	// Store the SP in from->sp
+%#
+		"cmp r2, r3				\n\t"	// Compare SP to from->bottom
 %% else
-		"str sp, [r0]		\n\t"	// Store the SP in from->sp
+		"str sp, [r0]			\n\t"	// Store the SP in from->sp
+%% if not with_psplim
+%#
+		"cmp sp, r3				\n\t"	// Compare SP to from->bottom
+%% endif
+%% endif
+%% if not with_psplim
+		"bls modm_context_end	\n\t"	// If SP <= bottom, stack overflow
+		"ldr r3, [r3]			\n\t"	// Load stack bottom
+		"ldr r2, =0xf00dcafe	\n\t"	// Load StackWatermark value
+		"cmp r2, r3				\n\t"	// Check if stack watermark is still at the bottom
+		"bne modm_context_end	\n\t"	// If not, stack overflow
 %% endif
 %#
 %% if is_cm0
-		"ldr r2, [r1]		\n\t"
-		"mov sp,  r2		\n\t"	// Restore SP from to->sp
+		"ldr r2, [r1]			\n\t"
+		"mov sp,  r2			\n\t"	// Restore SP from to->sp
 %% elif with_psplim
-		"ldm r1, {r1-r2}	\n\t"
-		"msr psplim, r2		\n\t"	// Set PSPLIM to ctx->bottom
-		"mov sp, r1			\n\t"	// Set PSP to ctx->sp
+		"ldm r1, {r1-r2}		\n\t"
+		"msr psplim, r2			\n\t"	// Set PSPLIM to ctx->bottom
+		"mov sp, r1				\n\t"	// Set PSP to ctx->sp
 %% else
-		"ldr sp, [r1]		\n\t"	// Restore SP from to->sp
+		"ldr sp, [r1]			\n\t"	// Restore SP from to->sp
 %% endif
 %#
 		MODM_POP_CONTEXT()
 	);
 }
 
 void modm_naked
-modm_context_end()
+modm_context_end(uintptr_t)
 {
 	asm volatile
 	(
-		"mrs r0, control	\n\t"
+		"mrs r1, control	\n\t"
 %% if is_cm0
-		"mov r1, #2			\n\t"
-		"bic r0, r0, r1		\n\t"	// Unset SPSEL
+		"mov r2, #2			\n\t"
+		"bic r1, r1, r2		\n\t"	// Unset SPSEL
 %% else
-		"bic r0, r0, #2		\n\t"	// Unset SPSEL
+		"bic r1, r1, #2		\n\t"	// Unset SPSEL
 %% endif
-		"msr control, r0	\n\t"
+		"msr control, r1	\n\t"
 
 		MODM_POP_CONTEXT()
 	);

src/modm/processing/fiber/context_arm_m.cpp.in

@@ -149,67 +149,90 @@ modm_context_stack_usage(const modm_context_t *ctx)
 bool
 modm_context_stack_overflow(const modm_context_t *ctx)
 {
-	return *p2u(ctx->bottom) != StackWatermark;
+	return ctx->sp < ctx->bottom or *p2u(ctx->bottom) != StackWatermark;
 }
 
 // Stores only the stack pointer of the main stack
 static uintptr_t main_context_sp;
 static_assert(offsetof(modm_context_t, sp) == 0);
 
-void
+uintptr_t
 modm_context_start(modm_context_t *to)
 {
 	modm_context_jump((modm_context_t*)&main_context_sp, to);
+	__builtin_unreachable();
 }
 
+extern "C" void
+modm_context_jump_return(uintptr_t, modm_context_t*);
+
 void modm_naked
 modm_context_jump(modm_context_t*, modm_context_t*)
 {
 	asm volatile
 	(
 		// Push callee-saved registers on stack
 		".irp regs, 2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,28,29	\n\t"
-		"push r\\regs 		\n\t"
-		".endr 				\n\t"
+		"push r\\regs 			\n\t"
+		".endr 					\n\t"
 
 		// Store the SP of current fiber
-		"mov ZL, r24		\n\t"
-		"mov ZH, r25		\n\t"
-		"in	r24, __SP_L__	\n\t"
-		"in	r25, __SP_H__	\n\t"
-		"st  Z+, r24		\n\t"
-		"st  Z,  r25		\n\t"
+		"mov ZL, r24			\n\t"
+		"mov ZH, r25			\n\t"
+		"in	r20, __SP_L__		\n\t"
+		"in	r21, __SP_H__		\n\t"
+		"std Z+1, r20			\n\t"
+		"st  Z,   r21			\n\t"
+
+		// Check for stack overflow via bottom
+		"ldd XL, Z+3			\n\t"
+		"ldd XH, Z+2			\n\t"
+		"cp  r20, XL			\n\t"
+		"cpc r21, XH			\n\t"
+		"brcs modm_context_end	\n\t"
+
+		// Check for stack overflow via watermark
+		"ld r20, X				\n\t"
+		"cpi r20, 0xaa			\n\t"
+		"brne modm_context_end	\n\t"
+
+	"modm_context_jump_return:	\n\t"
 
 		// Load the SP of next fiber
-		"mov ZL, r22		\n\t"
-		"mov ZH, r23		\n\t"
-		"ld  r22, Z+		\n\t"
-		"ld  r23, Z			\n\t"
+		"mov ZL, r22			\n\t"
+		"mov ZH, r23			\n\t"
+		"ld  r22, Z+			\n\t"
+		"ld  r23, Z				\n\t"
 
 		// Save SREG and disable interrupts
-		"in r24, __SREG__	\n\t"
-		"cli				\n\t"
+		"in r20, __SREG__		\n\t"
+		"cli					\n\t"
 
 		// Write the SP
-		"out __SP_L__, r22	\n\t"
-		"out __SP_H__, r23	\n\t"
+		"out __SP_L__, r22		\n\t"
+		"out __SP_H__, r23		\n\t"
 
 		// Re-enable interrupts by restoring SREG
-		"out __SREG__, r24	\n\t"
+		"out __SREG__, r20		\n\t"
 
 		// Pop callee-saved registers from stack
 		".irp regs, 29,28,17,16,15,14,13,12,11,10,9,8,7,6,5,4,3,2	\n\t"
-		"pop r\\regs		\n\t"
-		".endr				\n\t"
+		"pop r\\regs			\n\t"
+		".endr					\n\t"
 
-		"ret				\n\t"
+		"ret					\n\t"
 	);
 }
 
 void
-modm_context_end()
+modm_context_end(uintptr_t retval)
 {
-	uintptr_t dummy;
-	modm_context_jump((modm_context_t*)&dummy, (modm_context_t*)&main_context_sp);
+	modm_context_jump_return(retval, (modm_context_t*)&main_context_sp);
 	__builtin_unreachable();
 }
+
+
+
+
+
+

src/modm/processing/fiber/context_avr.cpp

@@ -21,7 +21,7 @@ def is_enabled(env):
         not env.has_module(":processing:protothread")
 
 def prepare(module, options):
-    module.depends(":architecture:clock", ":architecture:atomic")
+    module.depends(":architecture:clock", ":architecture:atomic", ":architecture:assert")
 
     module.add_query(
         EnvironmentQuery(name="__enabled", factory=is_enabled))
@@ -56,7 +56,7 @@ def build(env):
 
     if core.startswith("cortex-m"):
         env.substitutions["stack_minimum"] = (2 + 9 + (16 if with_fpu else 0)) * 4
-        env.substitutions["default_stack_size"] = 512
+        env.substitutions["default_stack_size"] = 1024
         env.template("context_arm_m.cpp.in")
 
     elif core.startswith("avr"):
@@ -77,7 +77,7 @@ def build(env):
     env.copy("context.h")
     env.template("stack.hpp.in")
     env.template("scheduler.hpp.in")
-    env.copy("scheduler.cpp")
+    env.template("scheduler.cpp.in")
     env.copy("task.hpp")
     env.copy("task_impl.hpp")
     env.copy("functions.hpp")