Skip to content

Commit c6c3a31

Browse files
committed
Make TransportUart inherit from UartDevice
1 parent da40e00 commit c6c3a31

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

src/modm/driver/radio/sx128x.lb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ def prepare(module, options):
2323
module.depends(
2424
":architecture:gpio",
2525
":architecture:spi.device",
26+
":architecture:uart.device",
2627
":math:utils",
2728
":processing:resumable",
2829
":processing:timer")

src/modm/driver/radio/sx128x_transport.hpp

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ class Sx128xTransportSpi : public Sx128xTransport, public modm::SpiDevice< SpiMa
123123
* @author Rasmus Kleist Hørlyck Sørensen
124124
*/
125125
template < class Uart >
126-
class Sx128xTransportUart : public Sx128xTransport
126+
class Sx128xTransportUart : public Sx128xTransport, public modm::UartDevice< Uart >
127127
{
128128
public:
129129
Sx128xTransportUart() = default;
@@ -138,14 +138,6 @@ class Sx128xTransportUart : public Sx128xTransport
138138
modm::ResumableResult<bool>
139139
readCommand(Command command, std::span<uint8_t> data);
140140

141-
private:
142-
143-
modm::ResumableResult<bool>
144-
write(uint8_t data);
145-
146-
modm::ResumableResult<bool>
147-
read(uint8_t *data);
148-
149141
private:
150142
uint8_t rxIndex;
151143
uint8_t txIndex;

0 commit comments

Comments
 (0)