Add simple logic to some commands

Author: rasmuskleist

src/modm/driver/radio/sx128x_impl.hpp

@@ -166,11 +166,16 @@ Sx128x< Transport, Busy >::setTx(PeriodBase periodBase, uint16_t periodBaseCount
 {
     RF_BEGIN();
 
+    // Clear IRQ status before using this command
+    RF_CALL(clearIrqStatus(Irq_t(0xFF)));
+
     buffer[0] = uint8_t(periodBase);
     buffer[1] = (periodBaseCount >> 8) & 0xFF;
     buffer[2] = periodBaseCount & 0xFF;
     RF_WAIT_WHILE(isBusy());
 
+    /// TODO: Determine if ranging role should be set here
+
     RF_END_RETURN_CALL(this->writeCommand(Opcode::SetTx, std::span{buffer, 3}));
 }
 
@@ -182,11 +187,16 @@ Sx128x< Transport, Busy >::setRx(PeriodBase periodBase, uint16_t periodBaseCount
 {
     RF_BEGIN();
 
+    // Clear IRQ status before using this command
+    RF_CALL(clearIrqStatus(Irq_t(0xFF)));
+
     buffer[0] = uint8_t(periodBase);
     buffer[1] = (periodBaseCount >> 8) & 0xFF;
     buffer[2] = periodBaseCount & 0xFF;
     RF_WAIT_WHILE(isBusy());
 
+    /// TODO: Determine if ranging role should be set here
+
     RF_END_RETURN_CALL(this->writeCommand(Opcode::SetRx, std::span{buffer, 3}) );
 }
 
@@ -302,7 +312,8 @@ Sx128x< Transport, Busy >::setTxParams(uint8_t power, RampTime rampTime)
 {
     RF_BEGIN();
 
-    buffer[0] = power;
+    // Compenstate for offset Pout = 18 – power
+    buffer[0] = 18 + power;
     buffer[1] = uint8_t(rampTime);
     RF_WAIT_WHILE(isBusy());
 
@@ -374,6 +385,8 @@ Sx128x< Transport, Busy >::getRxBufferStatus(RxBufferStatus *rxBufferStatus)
 
     RF_WAIT_WHILE(isBusy());
 
+    /// TODO: Determine if logic is different for different packet types
+
     RF_END_RETURN_CALL(this->readCommand(Opcode::GetRxBufferStatus, std::span{(uint8_t *) rxBufferStatus, 2}));
 }
 
@@ -387,6 +400,8 @@ Sx128x< Transport, Busy >::getPacketStatus(PacketStatus *packetStatus)
 
     RF_WAIT_WHILE(isBusy());
 
+    /// TODO: Determine if logic is different for different packet types
+
     RF_END_RETURN_CALL(this->readCommand(Opcode::GetPacketStatus, std::span{(uint8_t *) packetStatus, 5}));
 }
 
@@ -509,10 +524,13 @@ template < class Transport, class Busy >
 modm::ResumableResult<bool>
 Sx128x< Transport, Busy >::setAutoTx(uint16_t time)
 {
+    /// The delay between reception end and transmission start is offset by 33 us
+    uint16_t delay = time - 33;
+
     RF_BEGIN();
 
-    buffer[0] = (time >> 8) & 0xFF;
-    buffer[1] = time & 0xFF;
+    buffer[0] = (delay >> 8) & 0xFF;
+    buffer[1] = delay & 0xFF;
     RF_WAIT_WHILE(isBusy());
 
     RF_END_RETURN_CALL(this->writeCommand(Opcode::SetAutoTx, std::span{buffer, 2}));