Changelog & Ghost errors are no longer raised when threads are created using non-organic methods.

Author: fourjr

CHANGELOG.md

@@ -12,6 +12,12 @@ however, insignificant breaking changes do not guarantee a major version bump, s
 
 - `on_thread_initiate` and `on_thread_ready` events now have `thread, creator, category, initial_message` as additional arguments.
 
+### Fixed
+
+- `confirm_thread_creation` now properly works when a user opens a thread using react to contact. ([GH #2930](https://github.com/kyb3r/modmail/issues/2930), [PR #2971](https://github.com/kyb3r/modmail/pull/2971))
+- `?disable all/new` now disables react to contact threads. ([GH #2969](https://github.com/kyb3r/modmail/issues/2969), [PR #2971](https://github.com/kyb3r/modmail/pull/2971))
+- Ghost errors are no longer raised when threads are created using non-organic methods.
+
 ### Internal
 
 - `thread.reply` now returns (msg_to_user, msg_to_thread). Can be useful in plugins.

core/models.py

@@ -226,7 +226,8 @@ class DummyMessage:
     """
 
     def __init__(self, message):
-        message.attachments = []
+        if message:
+            message.attachments = []
         self._message = message
 
     def __getattr__(self, name: str):

core/thread.py

@@ -245,8 +245,8 @@ class Author:
             await self.bot.api.update_note_ids(ids)
 
         async def activate_auto_triggers():
-            message = DummyMessage(copy.copy(initial_message))
-            if message:
+            if initial_message:
+                message = DummyMessage(copy.copy(initial_message))
                 try:
                     return await self.bot.trigger_auto_triggers(message, channel)
                 except RuntimeError: