Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextjs-mf and NextJS 14.2.14+ issue #3079

Closed
5 tasks done
ciandt-crodrigues opened this issue Oct 14, 2024 · 8 comments
Closed
5 tasks done

Nextjs-mf and NextJS 14.2.14+ issue #3079

ciandt-crodrigues opened this issue Oct 14, 2024 · 8 comments

Comments

@ciandt-crodrigues
Copy link

Describe the bug

After the recent NextJS update, the nextjs-mf package starts falling with.

The target environment doesn't support dynamic import() syntax so it's not possible to use external type 'module' within a script

Import trace for requested module:
external "@headlessui/react"

This issue is fixed by either not applying the NextFederationPlugin (which defeats the purpose) or fixing the Nextjs version to 12.2.13 or less.

Something they did broke the plugin, maybe you could share some workaround?

attached is a somewhat small reproducible environment.

Reproduction

https://codesandbox.io/p/devbox/errordynamicimport-l6mzwq

Used Package Manager

npm

System Info

from CodeSandbox:

  System:
    OS: Linux 6.1 Debian GNU/Linux 12 (bookworm) 12 (bookworm)
    CPU: (2) x64 AMD EPYC
    Memory: 1.09 GB / 4.01 GB
    Container: Yes
    Shell: Unknown
  Binaries:
    Node: 20.11.1 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.4 - /usr/local/bin/npm
    pnpm: 8.15.4 - /usr/local/share/npm-global/bin/pnpm

Validations

@ciandt-crodrigues
Copy link
Author

The issue thrown is related to headlessui, and I know this is supposed to be a client-only package, but my code worked before and only stopped working on new versions of NextJS. It would be nice to have the code updated to work, but I understand you probably can't support all frameworks out there having at least a workaround would help me a ton.
This code works without using Module Federation. with app routing I think that the "use client" on the lib would work, but unfortunately, app router is a long way (if we make it at all)

@ScriptedAlchemy
Copy link
Member

nextjs-mf will not work with app router.
try it with pages router only and see if it works then

@ScriptedAlchemy
Copy link
Member

The problem is your build configuration. Clearly, vercel has shipped breaking changes yet again.

do this

   environment: {
        ...config.output.environment,
        asyncFunction: true,
        dynamicImport: true
      },

@rdenman
Copy link

rdenman commented Oct 21, 2024

@ScriptedAlchemy I'm having the same issue - adding asyncFunction & dynamicImport fixes my build, but I'm now getting errors at runtime: ReferenceError: __webpack_share_scopes__ is not defined

Here's my webpack config, am I missing something here?

webpack(config, { isServer }) {
    config.output.environment = {
      ...config.output.environment,
      asyncFunction: true,
      dynamicImport: true,
    };
    config.plugins.push(
      new NextFederationPlugin({
        name: "my_app",
        filename: "static/chunks/remoteEntry.js",
        remotes: { some_mfe: 'some_mfe@/some-mfe/remoteEntry.js` },
        shared: {
          "@my/my-ui-lib": { singleton: true,  requiredVersion: false },
          "@emotion/react": { singleton: true,  requiredVersion: false },
          "@emotion/styled": { singleton: true,  requiredVersion: false },
          "@mui/material": { singleton: true,  requiredVersion: false },
          "@tanstack/react-query": { singleton: true,  requiredVersion: false },
          i18next: { singleton: true,  requiredVersion: false },
          "next-i18next": { singleton: true,  requiredVersion: false },
          "react-i18next": { singleton: true,  requiredVersion: false }
        },
        extraOptions: {
          exposePages: true,
          debug: process.env.NODE_ENV === "development",
        },
      }),
    );

    return config;
  },

Happy to put together a repro repo if needed too.

This is for next@14.2.15, @module-federation/nextjs-mf@8.6.4. next@14.2.3 works just fine

@ScriptedAlchemy
Copy link
Member

Provide repo

@rdenman
Copy link

rdenman commented Oct 28, 2024

Sorry, I've been out for a bit and haven't had a chance to get a repo setup. Some later version of the nextjs-mf plugin seems to have resolved this, I can upgrade to latest next 14 and all's well.

@ScriptedAlchemy
Copy link
Member

Warning Support for next is ending

#3153

@ciandt-crodrigues
Copy link
Author

. Some later version of the nextjs-mf plugin seems to have resolved this, I can upgrade to latest next 14 and all's well.

@rdenman do you mind sharing the version of next-mf and next that are working for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants