-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/do not inject runtime into build time chunk(#3225) #3229
base: main
Are you sure you want to change the base?
Fix/do not inject runtime into build time chunk(#3225) #3229
Conversation
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fbb4034
to
16758b5
Compare
The merge operation for this pull request has been blocked. This might be because I don't have the necessary permissions to perform the merge, or perhaps my workflow was incorrect. Could you please help me how to complete this merge? |
@lnlfps are you a bytedance employee? If yes, I'll expedite the merge or ship a canary If no, I'll review it in the morning and prepare release if tests pass. |
@ScriptedAlchemy I am not an employee of ByteDance. Thanks very much for your response and assistance. I am planning to implement module federation in our UmiJS project. I see that there are a few of test cases failing. The reasons for the failures are exactly the issues I am currently encountering. When processing a style modules, the base mf runtime was not injected into the chunk context, but the share runtime was loaded, resulting in an undefined error. My method might not be complete, and I hope you have better solutions to address similar problems. |
@lnlfps please see CI errors |
Description
When working with umijs or father, during the compilation of less modules, some 'build time chunks' are generated. These temporary chunks lack chunkGraph information, leading to errors when generating runtime code.
Then The current chunk id is build time chunk, the variable this.compilation.chunkGraph is undefined,causing an exception to be thrown
Related Issue
#3225
Types of changes
Checklist