Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODX3 RC1 install fails on chrset change to UTF8 / UTF8ci #16003

Closed
wshawn opened this issue Jan 25, 2022 · 3 comments
Closed

MODX3 RC1 install fails on chrset change to UTF8 / UTF8ci #16003

wshawn opened this issue Jan 25, 2022 · 3 comments
Labels
bug The issue in the code or project, which should be addressed.

Comments

@wshawn
Copy link

wshawn commented Jan 25, 2022

Bug report

Summary

MODX3 still does not honor charset changes. As I have stated before latin is too limited and other charsets should be usable - especially when they are listed in the dropdown. This is not a new issue.

Step to reproduce

Change Charset to UTF8 / general-ci.

Observed behavior

Database test
Failure message. No error was provided (on screen or filesystem)

Expected behavior

How it should behave after following steps above.

Environment

MODX version: MODX Revolution 3.0.0-rc1 (traditional)
Version codename: Revolution
Database type: mysql
Database version: 10.2.41-MariaDB-cll-lve
Database charset: latin1

@wshawn wshawn added the bug The issue in the code or project, which should be addressed. label Jan 25, 2022
@Mark-H
Copy link
Collaborator

Mark-H commented Jan 25, 2022

This is an upstream issue modxcms/xpdo#175 - closing it here.

While it is true xPDO doesn't currently actually set the charset/collations even though it could (there's a patch here: modxcms/xpdo#192), the reason it's using latin1 is because the database was created with latin1 (or the server default of latin1). If you create the database properly before running the setup that will avoid this issue.

(Also very strongly recommend utf8mb4 over utf8 so you can use ✨ emojis ✨ but that's kinda off-topic)

@JoshuaLuckers
Copy link
Contributor

@wshawn Thanks for bringing this up again

@wshawn
Copy link
Author

wshawn commented Mar 21, 2022

1 is because the database was created with lati

I actually created the database with UTF8, not Latin. I create all my international databases in UTF8, as I really do not have any options. Thank you for looking into this. I have been busy converting some projects to Laravel 9 and failed to see this earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue in the code or project, which should be addressed.
Projects
None yet
Development

No branches or pull requests

3 participants