Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.1.0 Issue with New TV Template Assignment #16677

Closed
deJaya opened this issue Jan 13, 2025 · 1 comment · Fixed by #16678
Closed

3.1.0 Issue with New TV Template Assignment #16677

deJaya opened this issue Jan 13, 2025 · 1 comment · Fixed by #16678
Labels
bug The issue in the code or project, which should be addressed.

Comments

@deJaya
Copy link

deJaya commented Jan 13, 2025

Bug report

Summary

In MODX 3.1.0-pl sites - while creating a new TV, the list of Templates under the Template Access tab is blank on first visit.

Step to reproduce

Create a new TV. Click on the Template Access tab.

Observed behaviour

The list of available templates is blank on the first visit. Moving to another tab and then back to Template Access results in the list of Templates being successfully populated.

Expected behaviour

The list of available templates should be populated on the first visit.

Environment

MODX 3.1.0-pl

Some discussion here.

@deJaya deJaya added the bug The issue in the code or project, which should be addressed. label Jan 13, 2025
@smg6511
Copy link
Collaborator

smg6511 commented Jan 13, 2025

Confirmed. I'll take a look at this in the next couple days...

opengeek added a commit that referenced this issue Mar 24, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…#16678)

### What does it do?
Adds base grid method to differentiate the intent of the category URL
param, between being the value of a grid filter and that of the target
category for a new Element (when choosing _Create a [Element] Here_ via
the contextual menu), and applies the appropriate value for each
context.

### Why is it needed?
The Template Access grid initially is empty when a new Element is
created in the root (i.e., it has no category), because the value of the
category param is 'undefined'.

### How to test
1. Create new Elements of each type to verify normal operation.
2. Pay specific attention to the Template and TV Elements, where each
has an assignment grid (Template Variables and Template Access tabs
respectively). Verify these grids show as expected and are unfiltered
when creating a new Element and when editing an existing one.
3. On an existing Template and TV, go to the respective assignment grid
tab and use its category filter. Copy and paste the resulting URL (in
the browser URL bar) and copy that into a new browser tab. Verify that
the view in this new tab is the same as the previous tab where you
applied the filter. (This is to ensure the somewhat new feature of grid
filtering persistence via the URL still operates correctly.)

### Related issue(s)/PR(s)
Resolves #16677

---------

Co-authored-by: Jason Coward <jason@opengeek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue in the code or project, which should be addressed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants