Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Ignore model constants in platform classes in generating models (parse-schema) #189

Open
Mark-H opened this issue Feb 28, 2021 · 0 comments

Comments

@Mark-H
Copy link
Collaborator

Mark-H commented Feb 28, 2021

Given a model class like..

namespace Namespace\Model;
class SomeObject extends xPDOObject
{
    protected const SOME_CONSTANT = 'some relevant value';

... the created platform classes get:

namespace Namespace\Model\mysql;
class SomeObject extends \Namespace\Model\SomeObject
    const SOME_CONSTANT = 'some relevant value';

... which I don't necessarily want. Being able of disabling that (or, at the very least, keeping the same visibility) would be nice.

Related to #162 which fixed the constant values getting skipped entirely, which has since improved, but is still not ideal behavior in my humble opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant