Reserved param names?

[daleif]

The docs lists that for stash there are some reserved names. https://docs.mojolicious.org/Mojolicious/Controller#stash

How does these apply to param and taghelpers? (I fill param to have taghelpers pick up the values from the DB)

Just noticed while writing a test that a form select field of the name status never marks the selected option. All other selects does mark their selected value.

Should it just be obvious that the reserved stash names also apply to param parameters? Because it wasn't for me.

I'll just rename this form field through out my application, but it would be nice if this was noted in the documentation.

[kraih]

I have no idea what you mean.

$ perl -Mojo -E 'a(sub { $_->render(text => $_->param("status")) })->start' get /?status=123
123

[rmallah]

Another side effect of reserved stash key names is that we cannot use the same name
in db columns in case we are using certain OpenAPI related modules.

Sorry for the meager details but i could drill down a past debugging episode to this change.
I will try to come back again with more details.

[daleif]

Minimal exmaple

use Mojolicious::Lite -signatures;

# Render the template "index.html.ep"
get '/' => sub ($c) {
    $c->param( status => 'locked');
    $c->param( statusx => 'activex');
  $c->render;
} => 'index';


app->start;
__DATA__

@@ index.html.ep
%= select_field status => ['active', 'locked']
%= select_field statusx => ['activex', 'lockedx']

Running perl poc.pl get / I get

[2021-12-10 11:20:01.55745] [8805] [debug] [hrX56iyNK9gg] GET "/"
[2021-12-10 11:20:01.55770] [8805] [debug] [hrX56iyNK9gg] Routing to a callback
[2021-12-10 11:20:01.55806] [8805] [debug] [hrX56iyNK9gg] Rendering template "index.html.ep" from DATA section
[2021-12-10 11:20:01.55858] [8805] [debug] Your secret passphrase needs to be changed
[2021-12-10 11:20:01.55892] [8805] [debug] [hrX56iyNK9gg] 200 OK (0.001461s, 684.463/s)
<select name="status"><option value="active">active</option><option value="locked">locked</option></select>
<select name="statusx"><option selected value="activex">activex</option><option value="lockedx">lockedx</option></select>

Note how the first <select> has no selected in their options. But the second <select> does

[daleif]

I'm fine with status also being reserved in param data but then it should be documented.

[rmallah]

If the reserved names were encapsulated in a namespace eg mojo.* it would have nice in my humble opinion. I am stuck at mojo 8.x just because of this.

[kraih]

Yea, really nice... 🙄

$c->render('mojo.template' => 'index', 'mojo.format' => 'xml', 'mojo.status' => 200);

[rmallah]

sorry i did not realize its affects here , its not nice :-(

[kraih]

Fwiw. In mojo.js we've split render options and stash, so there is no status there. But i doubt that will ever make it back to Mojolicious, since it would break too many things.

[rmallah]

I will surely create a failing test case to put across the problem i face. Thanks.

[daleif]

Just to prove a point, running with 9.22:

use Mojolicious::Lite -signatures;
# https://docs.mojolicious.org/Mojolicious/Controller#stash
my @list = qw/action app cb
	      controller data
	      extends format
	      handler inline
	      json layout
	      namespace path
	      status template
	      text variant/;


# Render the template "index.html.ep"
get '/' => sub ($c) {

    for ( @list ) {
	$c->param( $_ => 'active' );
	$c->param( 'hmm_' . $_ => 'active' );
    }
    $c->stash(list => \@list);
    $c->render;
} => 'index';


app->start;
__DATA__

@@ index.html.ep
% for ( @$list ) {    
    %= select_field $_ => ['active', 'locked']
% }
% for ( @$list ) {    
    %= select_field 'hmm_' . $_ => ['active', 'locked']
% }

From perl file.pl get / I get

[2021-12-11 15:32:20.13731] [6010] [trace] [Z9eZyy-oI7Zu] GET "/"
[2021-12-11 15:32:20.13774] [6010] [trace] [Z9eZyy-oI7Zu] Routing to a callback
[2021-12-11 15:32:20.13850] [6010] [trace] [Z9eZyy-oI7Zu] Rendering template "index.html.ep" from DATA section
[2021-12-11 15:32:20.13967] [6010] [trace] Your secret passphrase needs to be changed
[2021-12-11 15:32:20.14227] [6010] [trace] [Z9eZyy-oI7Zu] 200 OK (0.004953s, 201.898/s)
    <select name="action"><option value="active">active</option><option value="locked">locked</option></select>
    <select name="app"><option value="active">active</option><option value="locked">locked</option></select>
    <select name="cb"><option value="active">active</option><option value="locked">locked</option></select>
    <select name="controller"><option value="active">active</option><option value="locked">locked</option></select>
    <select name="data"><option value="active">active</option><option value="locked">locked</option></select>
    <select name="extends"><option value="active">active</option><option value="locked">locked</option></select>
    <select name="format"><option value="active">active</option><option value="locked">locked</option></select>
    <select name="handler"><option value="active">active</option><option value="locked">locked</option></select>
    <select name="inline"><option value="active">active</option><option value="locked">locked</option></select>
    <select name="json"><option value="active">active</option><option value="locked">locked</option></select>
    <select name="layout"><option value="active">active</option><option value="locked">locked</option></select>
    <select name="namespace"><option value="active">active</option><option value="locked">locked</option></select>
    <select name="path"><option value="active">active</option><option value="locked">locked</option></select>
    <select name="status"><option value="active">active</option><option value="locked">locked</option></select>
    <select name="template"><option value="active">active</option><option value="locked">locked</option></select>
    <select name="text"><option value="active">active</option><option value="locked">locked</option></select>
    <select name="variant"><option value="active">active</option><option value="locked">locked</option></select>
    <select name="hmm_action"><option selected value="active">active</option><option value="locked">locked</option></select>
    <select name="hmm_app"><option selected value="active">active</option><option value="locked">locked</option></select>
    <select name="hmm_cb"><option selected value="active">active</option><option value="locked">locked</option></select>
    <select name="hmm_controller"><option selected value="active">active</option><option value="locked">locked</option></select>
    <select name="hmm_data"><option selected value="active">active</option><option value="locked">locked</option></select>
    <select name="hmm_extends"><option selected value="active">active</option><option value="locked">locked</option></select>
    <select name="hmm_format"><option selected value="active">active</option><option value="locked">locked</option></select>
    <select name="hmm_handler"><option selected value="active">active</option><option value="locked">locked</option></select>
    <select name="hmm_inline"><option selected value="active">active</option><option value="locked">locked</option></select>
    <select name="hmm_json"><option selected value="active">active</option><option value="locked">locked</option></select>
    <select name="hmm_layout"><option selected value="active">active</option><option value="locked">locked</option></select>
    <select name="hmm_namespace"><option selected value="active">active</option><option value="locked">locked</option></select>
    <select name="hmm_path"><option selected value="active">active</option><option value="locked">locked</option></select>
    <select name="hmm_status"><option selected value="active">active</option><option value="locked">locked</option></select>
    <select name="hmm_template"><option selected value="active">active</option><option value="locked">locked</option></select>
    <select name="hmm_text"><option selected value="active">active</option><option value="locked">locked</option></select>
    <select name="hmm_variant"><option selected value="active">active</option><option value="locked">locked</option></select>

and thus none of the reserved stash values can be used to fill tags made via the taghelpers plugin

This ought to be mentioned in the documentation.

[kraih]

Or it should be fixed if it is a bug.

[daleif]

Should I log it as an issue then instead?