Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daylight savings messes with parsing "[x] weeks from [date] at [time] #366

Open
bawolf opened this issue Oct 19, 2017 · 1 comment
Open
Labels

Comments

@bawolf
Copy link

bawolf commented Oct 19, 2017

Today is October 19th, 2017 and daylight savings is October 31st, 2017. I tried the following code:

> Chronic.parse('three weeks from monday at 9am')
2017-11-06 08:00:00 -0500

It seems to calculate "exactly three weeks" as in "724hrs2" from "Monday at 9am" which is actually 2017-11-06 08:00:00 -0500 because the day of daylight savings is 25 hours long. I would expect it to calculate "three weeks from Monday" as the date, and "9am" as the time.

To me it should return the same result as

> Chronic.parse('November 6th at 9am')
2017-11-06 09:00:00 -0500
@davispuh
Copy link
Collaborator

it's a known DST issue #344 but it's fixed in my rewrite branch #347 and works there fine.

@davispuh davispuh added the bug label Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants