Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Idea]: Status Icon hardcoded #44

Open
lukeholder opened this issue Jun 10, 2024 · 1 comment
Open

[Idea]: Status Icon hardcoded #44

lukeholder opened this issue Jun 10, 2024 · 1 comment
Labels
v3 Planned for v3

Comments

@lukeholder
Copy link

What happened?

The Status enum can support \Filament\Support\Contracts\HasIcon so instead of hardcoding the header icon:

https://github.com/mokhosh/filament-kanban/blob/main/resources/views/kanban-header.blade.php#L2

It should get the status icon.

CleanShot 2024-06-11 at 01 05 59@2x

How to reproduce the bug

Hardcoded status icon: ❖ in header view

Package Version

2.7.0

PHP Version

8.3.2

Laravel Version

11

Which operating systems does with happen with?

No response

Which browsers does with happen with?

No response

Notes

No response

@lukeholder lukeholder added the bug Something isn't working label Jun 10, 2024
@mokhosh mokhosh added v3 Planned for v3 and removed bug Something isn't working labels Jun 14, 2024
@mokhosh
Copy link
Owner

mokhosh commented Jun 14, 2024

Thanks for the idea.

@mokhosh mokhosh changed the title [Bug]: Status Icon hardcoded [Idea]: Status Icon hardcoded Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 Planned for v3
Projects
None yet
Development

No branches or pull requests

2 participants